HaikuDepot number formatting does not respect system settings

[bitigchi]

In Turkish, numbers are formatted as such: 1.234,56; , being the decimal separator. In HaikuDepot, download percentage indicator uses . for the decimal separator.

In addition, in Turkish % precedes the number, e.g., %56,5. HaikuDepot displays the % sign after the number as well.

I am not sure if this is 100% percent HaikuDepot bug, but have yet to observe this behaviour elsewhere.

[apl-haiku]

Looking in BFormattingConventions::GetNumericFormat, it doesn't look like the number formatting is implemented. Leave this open and hopefully it will be dealt with later.

[pulkomandy]

You can use ​https://git.haiku-os.org/haiku/tree/headers/os/locale/NumberFormat.h to format numbers in the system selected locale.

[apl-haiku]

Out of interest, in a couple of days, can you please try the nightly and see if it appears with the right formatting for the Turkish locale?

[bitigchi]

Replying to apl-haiku:

Out of interest, in a couple of days, can you please try the nightly and see if it appears with the right formatting for the Turkish locale?

I tried hrev54982, and the percentage sign is correctly displayed preceding the number. Thank you very much! It looks like the only part left is the decimal separator.

[apl-haiku]

It seems the ICU percentage formatting is not doing fractional percentages so I will leave it without the fractional part.

[bitigchi]

Yes, that was also another thing I've noticed. Download progress was only incrementing by integers.

[pulkomandy]

I think numberFormat->setMaximumFractionDigits() can be used to change that (​https://unicode-org.github.io/icu-docs/apidoc/dev/icu4c/classicu_1_1NumberFormat.html#a896f4fe4227dd472670f5d4c574d449a )

[apl-haiku]

Hmmm... I am reading that the ICU NumberFormat instances are not thread safe [1] anyway so I guess it is safe to adjust the NumberFormat held by the BNumberFormatImpl on the fly.

[1] ​https://stackoverflow.com/questions/37521746/thread-safe-dynamic-pattern-for-numberformat-decimalformat

[pulkomandy]

Yes, I had discussed thread safety issues when designing the API and the conclusion was that BeAPI things are usually not thread safe on their own, and it's up to application designers to avoid sharing objects between different threads, or set up their own locking.

In most cases you will be using objects inside a single looper so you are "automatically" safe. In cases where you do something else, you are on your own.

The exception to that is the global objects like BLocaleRoster default instance. In that case, the locale kit does its own locking and uses BMutableLocaleRoster to do the mutable parts (where BLocaleRoster doesn't allow any change to settings, so it has no thread safety problems).

[bitigchi]

I've started converting the numbers system-wide to use the NumberFormat, but without decimal formatting it gets real unpleasant layout-wise when the decimals increase at will. I will need to wait until this gets implemented.

I've started fixing the percentages as well, and will push my changes soon (once my Gerrit is fixed). Most of the percentages do not require decimals, so they should be good to go.

Also, once all the numbers are converted, it would be nice to have a global thousands separator display switch, like in other OS.