Sound distorted after update

[Starcrasher]

After update, I'm hearing distortion on wav files when played by system (startup sound) at startup, in Sounds prefs or with MediaPlayer. If a library is used, (i.e using playsound command line) there's no distortion. Using another app (i.e audacious, qmmp) to play same sound will also work. It doesn't seem to affect other sounds either watching a vid or playing a radio works.

This is on nightly hrev54858 x86_64

[waddlesplash]

What was the previous hrev you were on?

[madmax]

Reverting hrev54858 works for me. Though that's just because having less reserved memory triggers the real problem. Changing ​ChunkCache::SpaceLeft to add B_PAGE_SIZE instead of 2048 when in the heuristic also works for me, maybe by chance.

The problem is in ChunkCache::ReadNextChunk when we have to allocate a new buffer. We first ask the reader to get the next chunk. Now we know the size we need and rtm_malloc a new buffer if needed. If that allocation fails... well, bad luck, chunk is lost.

[Starcrasher]

Previous state was hrev54850 and it works.

Don't know if it can help but commit of hrev54858 says "Untested. If audio is not decoding well, try increasing the constant."...

[X512]

Don't know if it can help but commit of hrev54858 says "Untested. If audio is not decoding well, try increasing the constant."...

You can try to increase value 2000 here: ​https://git.haiku-os.org/haiku/tree/src/kits/media/MediaExtractor.cpp#n454.

[pulkomandy]

Some discussion here: ​https://review.haiku-os.org/c/haiku/+/3610

The buffer size for audio needs to be increased. Discussions in progress to try to find what a good guess would be for the size to allocate.

[pulkomandy]

Fixed in hrev54900.