[HaikuDepot] draw selection faster

[diver]

When selecting packages (in Featured packages view) there is a slight delay before the selection is being drawn. At the same time in the status bar appears the following message: Recording view of %PackageName%. Not sure if it's related though.

[apl-haiku]

Hi there; There are some recent change in this area. The message is because it is communicating back to HDS to record that somebody has viewed the package. Does it really have %PackageName% in the message in the status bar for you? I have just checked at my end and it definitely doesn't include %PackageName% in the message.

I can't see a perceptible delay here, but my current computer is a bit faster than my old one so maybe it's too quick for me to see. Is anybody else seeing the delay mentioned above? Maybe it is to do with the initiating of the status bar, layout and messaging. I might see if it can skip that if the process runs really quickly.

[humdinger]

FWIW, I don't see that either with my rather fast, 7 years old (oh my, how time flies...) 8 core i7-4712MQ, 2,3 GHz.
This is on hrev55009, 64 bit. The ticket's version is set to "beta2". Maybe something changed since then (or the ticket's version isn't correct...)?

[diver]

Sorry for the confusion HD is actually shows correct package name in Recording view of message. The delay is there in VMware Fusion.

[apl-haiku]

I've loaded up VirtualBox with 25% of one CPU core so it's very slow. Indeed it's slow to boot! Even with this limitation it is rendering the selected package very quickly; almost immediately. I am unable to reproduce this problem.

[diver]

Clicking on a package produces this output:

{I} found deskbar entry: data/deskbar/menu/Applications/KolourPaint -> ../../../../apps/KolourPaint/KolourPaint
{I} adding and starting a process coordinator [IncrementViewCounter]
{I} [Node<IncrementViewCounterProcess>] initiating
{I} [Node<IncrementViewCounterProcess>] starting process
{I} found deskbar entry: data/deskbar/menu/Applications/KolourPaint -> ../../../../apps/KolourPaint/KolourPaint
{I} did increment the view counter for [kolourpaint]
{I} process coordinator [IncrementViewCounter] did complete

My guess is that HD checks for the screenshot online and only then draws the selection. Or maybe it increments view counter before doing the drawing.

[diver]

Found out that this is caused by "Sharing anonymous usage data" option. Disabling it speeds package selection considerably.

Also on every selection I see the following in the log:

{E} post-json; request to endpoint [.../user-rating/search-user-ratings] failed with http status [0]
{E} unable to retrieve user ratings

[waddlesplash]

I disabled statistics collection in hrev56080 due to this and also #17689. It can be reenabled when it is fixed.

[apl-haiku]

Also on every selection I see the following in the log:

I found the cause of this one; it seems to be an issue in HDS which I will patch in the next version -- it's in master now. This is not directly related to this problem.