Opened 4 years ago

Closed 3 years ago

#16943 closed bug (fixed)

Update to Gerrit 3.3

Reported by: pulkomandy Owned by: kallisti5
Priority: normal Milestone: Unscheduled
Component: Website/Gerrit Version: R1/beta2
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

The oauth plugin for Gerrit 3.0 is using a deprecated way to communicate with Github and sending us email warnings:

---------- Forwarded message ---------
From: Haiku <noreply@github.com>
Date: Fri, May 7, 2021 at 6:13 PM
Subject: [GitHub API] Deprecation notice for authentication via URL
query parameters
To:


Hello there!

On May 7th, 2021 at 22:13 (UTC) your application (Haiku Gerrit) used
an access token (with the User-Agent Java/1.8.0_212) as part of a
query parameter to access an endpoint through the GitHub API.

https://api.github.com/user

Please use the Authorization HTTP header instead as using the
`access_token` query parameter is deprecated.

Depending on your API usage, we'll be sending you this email reminder
on a monthly basis.

Visit https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param
for more information about suggested workarounds and removal dates.

Thanks,
The GitHub Team

This issue was fixed in version 3.1 of the plugin.

I see in the infrastructure repo that an attempt to update to 3.2 was started but was unsuccesful. The linked issue is fixed in 3.3.

So, it looks like we can either update to 3.1, or directly to 3.3. In any case, we should do something before Github actually blocks us from logging in to our Gerrit.

Thanks!

Change History (1)

comment:1 by kallisti5, 3 years ago

Resolution: fixed
Status: newclosed

We're on Gerrit 3.2, so this one is resolved for now :-)

We can upgrade to 3.3 as it matures.

Note: See TracTickets for help on using tickets.