Opened 3 years ago
Closed 20 months ago
#16944 closed enhancement (fixed)
Embed hrev into haiku_loader
Reported by: | beaglejoe | Owned by: | davidkaroly |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | System/Boot Loader | Version: | R1/beta2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description (last modified by )
It would be helpful for bug reporting to have the boot loader executable versioned somehow.
Since the user must manually copy it from the install medium and it is not updated after that, there is currently no way to know what version is being used.
Attachments (3)
Change History (12)
by , 3 years ago
Attachment: | above-copyright.png added |
---|
by , 3 years ago
Attachment: | Bottom-right.png added |
---|
comment:1 by , 3 years ago
comment:2 by , 20 months ago
Owner: | set to |
---|---|
Status: | new → in-progress |
by , 20 months ago
Attachment: | embed-hrev.patch added |
---|
comment:4 by , 20 months ago
@davidkaroly,
Hello, I have attached a patch that I have been using locally. I hope that you find it helpful. It currently puts the hrev in both the top center AND the bottom right. You'll probably want to pick one or the other.
Also, I forgot to bump the copyright date to 2022 in:
src/system/boot/platform/generic/text_menu.cpp
comment:5 by , 20 months ago
Cool, thanks.
I have some code already for this in gerrit (for all bootloader platforms), I'll take a look at your patch and try to combine the best parts of the two versions.
comment:6 by , 20 months ago
Component: | System/Boot Loader/EFI → System/Boot Loader |
---|---|
Description: | modified (diff) |
Summary: | Embed hrev into haiku_loader.efi → Embed hrev into haiku_loader |
comment:7 by , 20 months ago
first attempt: hrev56510
the EFI loader looks good, we still need a fixup for the BIOS loader
comment:8 by , 20 months ago
fix for BIOS loader merged in hrev56520
verified in qemu with BIOS boot and TianoCore
comment:9 by , 20 months ago
Resolution: | → fixed |
---|---|
Status: | in-progress → closed |
I have prototyped this using the same technique used to embed the hrev into libbe.
Here it is embedded into the pe executable haiku_loader.efi
I think it looks better in the bottom right (or possibly centered at the bottom)