Embed hrev into haiku_loader

[beaglejoe]

It would be helpful for bug reporting to have the boot loader executable versioned somehow.

Since the user must manually copy it from the install medium and it is not updated after that, there is currently no way to know what version is being used.

[beaglejoe]

I have prototyped this using the same technique used to embed the hrev into libbe.

Here it is embedded into the pe executable haiku_loader.efi

I think it looks better in the bottom right (or possibly centered at the bottom)

[davidkaroly]

we could do this for all platforms, not only EFI

[beaglejoe]

@davidkaroly, Hello, I have attached a patch that I have been using locally. I hope that you find it helpful. It currently puts the hrev in both the top center AND the bottom right. You'll probably want to pick one or the other. Also, I forgot to bump the copyright date to 2022 in:

src/system/boot/platform/generic/text_menu.cpp

[davidkaroly]

Cool, thanks.

I have some code already for this in gerrit (for all bootloader platforms), I'll take a look at your patch and try to combine the best parts of the two versions.

see: ​https://review.haiku-os.org/c/haiku/+/5693

[davidkaroly]

first attempt: hrev56510

the EFI loader looks good, we still need a fixup for the BIOS loader

[davidkaroly]

fix for BIOS loader merged in hrev56520

verified in qemu with BIOS boot and TianoCore