Opened 3 years ago

Closed 3 years ago

#16949 closed task (fixed)

Add bot users to gerrit

Reported by: madmax Owned by: kallisti5
Priority: normal Milestone: Unscheduled
Component: Website/Gerrit Version:
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

We have a Verified label, but no way to use it, AFAICT. I'm currently building master with gerrit changes, and one of GSoC projects is to run style checkers in concourse for the patches. So I wonder if it would be a good idea to:

  1. Add bot users to the "Non-Interactive Users" group (or a new one)
  2. Give that group permissions to set Verified: -1..+1, and maybe Code-Review: -2..+1 labels

While there's currently procedure for 2 via a change request for the project config, I think 1 requires an admin.

If accepted, please create a user for the builder and send me its id and HTTP password. It doesn't need email, so something like gerrit create-account --group "'Non-Interactive Users'" --http-password some_gibberish a_nice_name would do for me.

Change History (2)

comment:1 by pulkomandy, 3 years ago

New change to add permission to the non-interactive users to use the Verified label: ​https://review.haiku-os.org/c/All-Projects/+/3936

I think bots should not get the Code-Review permission. The point of "Verified" is to clearly separate the review by bots (Verified) and the review by humans (Code-Review). Currently a +2 by an human is required before a change can be merged. The Verified +1 by bot will be informative only, but we can also make it mandatory if we are happy with the bot behavior and reliability later on (or we can add more detailed labels as we see fit).

I have created the user and am sending you the login and password by email.

comment:2 by madmax, 3 years ago

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.