Opened 6 months ago

Closed 6 months ago

#17405 closed bug (fixed)

webkit: IntersectionObserver broken or unimplemented

Reported by: nephele Owned by: pulkomandy
Priority: normal Milestone: Unscheduled
Component: Kits/Web Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

Change History (6)

comment:1 by pulkomandy, 6 months ago

It is a runtime enabled feature. See for example setIntersectionObserverEnabled in WebKitLegacy/mac/WebView/WebPreferences.mm.

So it needs to be enabled somehow.

in WTF/Scripts/Preferences/WebPreferencesExperimental.yaml, it is enabled by default for WebKit but not WebKitLegacy.

Do you need it for anything specific?

Last edited 6 months ago by pulkomandy (previous) (diff)

comment:2 by nephele, 6 months ago

It's abscence is a possible cause for these two tickets:
https://dev.haiku-os.org/ticket/17325
https://dev.haiku-os.org/ticket/17404

comment:3 by pulkomandy, 6 months ago

You can see how I changed the setting for image scaling here: https://github.com/haiku/haikuwebkit/commit/8198852ff648facbaf5c2dc0ff71a1086ce694bd

IF you want to try enabling this other setting you can do it in the ame way. Let me know if it helps with these bugs. Unfortunately it requires recompiling about 700 files, which takes a while.

comment:4 by nephele, 6 months ago

Enabeling IntersectionObserver fixes the github branch overview combobox for me, don't know about the merge button. It also fixed that other tickets site.

comment:5 by nephele, 6 months ago

My git server is beeing particularily picky about not wanting anything pushed today, so here is the patch inline :/

From f62bedc9890475bac30ecd822fd1dd2ff09b6148 Mon Sep 17 00:00:00 2001
From: Pascal Abresch <nep@packageloss.eu>
Date: Sat, 20 Nov 2021 11:36:21 +0100
Subject: [PATCH] Haiku: enable IntersectionObserverEnabled

This fixes rendering of github branch view
---
 .../WTF/Scripts/Preferences/WebPreferencesExperimental.yaml  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml b/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
index 6567e8d94e..6d950e6899 100644
--- a/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
+++ b/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
@@ -499,7 +499,7 @@ FTPEnabled:
       default: false
     WebKitLegacy:
       default: false
-      
+
 # FIXME: This seems to be accidentally enabled for WebKit1 right now due to the old code using the
 # wrong preference key in some places. We should identify whether it really makes sense to keep this
 # enabled.
@@ -670,6 +670,7 @@ IntersectionObserverEnabled:
   humanReadableDescription: "Enable Intersection Observer support"
   defaultValue:
     WebKitLegacy:
+      PLATFORM(HAIKU): true
       default: false
     WebKit:
       default: true
@@ -1203,7 +1204,7 @@ ScreenCaptureEnabled:
       default: false
     WebCore:
       default: false
-      
+
 ScrollToTextFragmentEnabled:
   type: bool
   humanReadableName: "Scroll To Text Fragment"
-- 
2.30.2

comment:6 by nephele, 6 months ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.