Opened 8 months ago

Closed 6 months ago

#17325 closed bug (fixed)

Can't merge PRs on github

Reported by: humdinger Owned by: pulkomandy
Priority: normal Milestone: R1/beta4
Component: Kits/Web Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #17404
Platform: All

Description

This is hrev55476, 64bit.

The box used to merge PRs now only shows a turning-wheel.

Web+'s script console says;

:0:0: Unrecognized Content-Security-Policy directive 'manifest-src'.
:0:0: Unrecognized Content-Security-Policy directive 'worker-src'.
https://github.githubassets.com/assets/chunk-vendor-5e210fe5.js:148:35047: Unhandled Promise Rejection: ReferenceError: Can't find variable: IntersectionObserver
https://github.githubassets.com/assets/chunk-vendor-5e210fe5.js:148:35047: Unhandled Promise Rejection: ReferenceError: Can't find variable: IntersectionObserver
https://github.githubassets.com/assets/chunk-vendor-5e210fe5.js:148:35047: Unhandled Promise Rejection: ReferenceError: Can't find variable: IntersectionObserver
https://github.githubassets.com/assets/chunk-vendor-5e210fe5.js:148:35047: Unhandled Promise Rejection: ReferenceError: Can't find variable: IntersectionObserver
https://github.githubassets.com/assets/chunk-vendor-5e210fe5.js:148:35047: Unhandled Promise Rejection: ReferenceError: Can't find variable: IntersectionObserver

If that's at all related...

Change History (5)

comment:1 by diver, 6 months ago

Blocking: 17404 added

comment:2 by nephele, 6 months ago

It's possible that it related, one other option could be heuristics on githubs site in relation to user agents.

I've created a ticket to track the state of IntersectionObserver anyhow: https://dev.haiku-os.org/ticket/17405

comment:4 by humdinger, 6 months ago

Indeed, merging is possible again, thanks a lot!

The merge-button itself is still just visible by its outline, because it's white text on almost white background...

comment:5 by nephele, 6 months ago

Milestone: UnscheduledR1/beta4
Resolution: fixed
Status: newclosed

Not sure about the outline, since I am always on dark mode (and have never seen the merge button :D)

maybe a second ticket with a screenshot would be neat, thanks :)

Note: See TracTickets for help on using tickets.