Opened 2 years ago
Last modified 2 years ago
#17587 new task
Deprecate B_SHINE_COLOR and B_SHADOW_COLOR
| Reported by: | pulkomandy | Owned by: | nobody |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | Kits/Interface Kit | Version: | R1/beta3 |
| Keywords: | Cc: | nephele | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
There are currently too much color constants available in appearance preferences. This is not very useful and makes it hard to create a nice theme. They also did not exist in BeOS (https://github.com/jscipione/r5headers/blob/master/headers/be/interface/InterfaceDefs.h).
In Haiku sources, B_SHADOW_COLOR is used only in DiskProbe (where it was recently added) and WindowShade (just because it has all the color constants). B_SHINE_COLOR is additionally used once in Tracker.
These colors are set in appearance to pure white and pure black. This does not seem very useful to use directly. And instead of using it for mixing with other colors, it looks like tint_color can be used instead.
I suggest to remove these two colors from the settings in appearance preferences, remove their usage from Haiku sources, and remove the constant definitions from the public API. ui_color would still accept the constant for BeOS compatibility and for any app that may access this color.
There is also some use in existing apps and in UI bindings or libraries (Beam, Qt haiku plugin, and Torrentor mainly). I think these can be patched to remove it and hardcode black and white instead.
