Scroll Increments in Terminal Suboptimal

[bonefish]

hrev23895. Real hardware and VMware.

Scrolling by mouse wheel or by scroll bar arrows scrolls only by one pixel per step/click. Clicking the scroll bar (above or below the handle) scrolls only by about half a line. The better increments would be one complete line and one complete page (maybe minus one line) respectively.

[jackburton]

Should be fixed in hrev23913

[bonefish]

Works better now. The page-wise scrolling increment should be adjusted when the window size is changed, though.

[jackburton]

Replying to bonefish:

Works better now. The page-wise scrolling increment should be adjusted when the window size is changed, though.

That should be done in hrev23914.

[bonefish]

Replying to jackburton:

Replying to bonefish:

Works better now. The page-wise scrolling increment should be adjusted when the window size is changed, though.

That should be done in hrev23914.

Sorry, I should have made that clearer: I tested with hrev23921 and just retested with hrev23930. It doesn't work. Can be easily seen, if you do a "seq 100" and play with the Terminal window size. It always scrolls by the initial size.

[jackburton]

Yeah you're right. I moved the call to SetSteps() to FrameResized(), so it's called also when the window is resized. I tested as you suggested and it looks okay now (except for other weird bugs like missing invalidation, wrong view repositioning and stuff like that, not caused by my changes) but I'll fix them later.