Opened 3 years ago
Last modified 3 years ago
#17743 reopened bug
Haiku Github repo does not have any Git Tags
Reported by: | mbrumbelow | Owned by: | haiku-web |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Sys-Admin | Version: | |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
Haiku repo @ https://github.com/haiku/haiku does not have any tags. This makes it difficult to build from this repo.
Change History (7)
comment:1 by , 3 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
comment:2 by , 3 years ago
This might help
git remote add gerrit https://review.haiku-os.org/haiku.git git fetch --tags gerrit
follow-up: 5 comment:3 by , 3 years ago
Resolution: | invalid |
---|---|
Status: | closed → reopened |
I think we should stop using tags for this.
We set this up because at the time git rev-count either did not exist or was very slow. This has long since be fixed. We could change our scripts to use git rev-count to determine the number of commits since the last release, or since the beginning of the history. Then we could completely remove the need for hrev tags.
It will result in a bump in the hrev number (since we would be counting commits instead of pushed) and will not be backward compatible (it will not determine the same number as the hrev tags). But for the future it would work well enough (probably better, in fact).
comment:4 by , 3 years ago
Milestone: | R1/beta4 → Unscheduled |
---|
comment:5 by , 3 years ago
Replying to pulkomandy:
I think we should stop using tags for this.
We set this up because at the time git rev-count either did not exist or was very slow. This has long since be fixed. We could change our scripts to use git rev-count to determine the number of commits since the last release, or since the beginning of the history. Then we could completely remove the need for hrev tags.
Doesn't 'git rev-count' require a full local copy?
comment:6 by , 3 years ago
So far as I know, it does indeed. So that will not work for anyone with shallow checkouts.
comment:7 by , 3 years ago
You need a copy including the tag you base the rev-count on. So you need a full clone only if you want to count from the very first commit in our git history. We could do rev-count from the last release branching hoint or some other arbitrary place.
Unfortunately this is by design; GitHub really does not handle tens of thousands of tags well an the web interface gets pretty slow, in past testing. You will have to manually set a hrev or pull the tags from the main repo.