"General Protection Error" during boot

[widespace_]

On hrev56326 trying to boot results in the kernel panicking with a "General Protection Error" without "turning on" any of the boot indicators. It does not appear to generate a syslog.

[widespace_]

Image of KDL output

[widespace_]

I just checked and hrev56325 boots fine so the problematic change is between these two revisions.

[korli]

Thanks. How much RAM on this computer? ​https://github.com/haiku/haiku/blob/e83979afa4cf62fd7980a863da80be11644feabe/src/system/kernel/fs/EntryCache.cpp#L87 looks like it checks against 1MB instead of 1GB.

[widespace_]

The computer has 32GB of RAM.

[waddlesplash]

shaka reported something similar via IRC: ​https://matrix.org/_matrix/media/r0/download/matrix.org/cptKGazpyXmnOZZLmeHyiItT/ima_9f0a5f2.jpeg

korli, how does that check 1MB? 1024^3 is the number of bytes in 1GB. Anyway 32GB of RAM is obviously more than enough for this. I'm not sure how we wound up with a crash here, in the worst case we'd get a NULL dereference but this isn't even that.

[waddlesplash]

Seems more likely that the refactoring changes somehow caused this, really, not the last commit to have larger cache sizes.

[waddlesplash]

Aha, it's the destructor being called. I need to add a NULL set.

[waddlesplash]

Should be fixed in hrev56330, please test.

[korli]

korli, how does that check 1MB?

Right, read too much strange code. The coding style didn't help either, "1024 * 1024 * 1024" would be more readable...

[widespace_]

Replying to waddlesplash:

Should be fixed in hrev56330, please test.

It appears to be fixed, hrev56332 boots fine.