Web+: all downloads fail with curl backend

[humdinger]

This is hrev56578+31, 64bit.
HaikuWebKit 1.9.0
WebKit 615.1.10

Trying to download anything opens the Download window, but the transfer never starts.

I'm setting the prio to "blocker" because I don't think we can release a beta with a browser that cannot download.

[waddlesplash]

It appears there is a separate class in the Curl network backend for handling downloads: ​https://github.com/haiku/haikuwebkit/blob/haiku/Source/WebCore/platform/network/curl/CurlDownload.cpp

The Windows version of WebKitLegacy has separate files for downloads for each of the network backends it supports: ​https://github.com/haiku/haikuwebkit/blob/haiku/Source/WebKitLegacy/win/WebDownloadCurl.cpp

Likely we need to do the same for our versions of WebDownload.

[pulkomandy]

Please try with ​https://github.com/haiku/haikuwebkit/commit/3f103ec359f4056ad9d113d3117fa8d5645b0a6c

[vidrep]

Not working on 64 bit after building HaikuWebKit (master).

[pulkomandy]

Some pieces were still missing, now it's working with ​https://github.com/haiku/haikuwebkit/commit/ff40d19c762705a18ea810a215aad34b14ee119f.

[bbjimmy]

Still broken in haikuwebkit1.9.1

[humdinger]

Works here with, too, hrev56578+43, 64bit, and HaikuWebKit 1.9.1

[humdinger]

Hold it. "Normal" downloads, like an image of a website or a nightly Haiku now work fine.

But: I just tried to download a catkeys ZIP provided by Polyglot and that fails, though differently than described in this ticket (though maybe related?):

• Go to ​https://i18n.kacperkasper.pl, login with your github account.
• Choose a project.
• Click e.g. on "Export languages - only completed"

That should download a ZIP with all finished translations. The Download window opens, but instead of the ZIP, an enrry named "login" appears. The progress bar is green, signaling success, but nothing was downloaded.
Works with other browsers.

There's nothing in Terminal or Web+ Script console.

Maybe some redirect issue?

New ticket?