Icon spacing at high resolutions is too wide

[zdykstra]

On a 4k screen, the horizontal (and possibly the vertical) spacing between icons seems to be too large.

Attached are two screen shots, one with the default spacing and one with gridOffset and offsetValue in PoseView.cpp both set to 0.625f.

I don't have enough hands-on experience with PoseView to know how the previous values were derived, but the change does seem to be closer to what I'd expect icon spacing to be.

[zdykstra]

Default spacing, 64x64, 4k

[zdykstra]

0.625 gridOffset, 64x64, 4k

[waddlesplash]

I made up the value when I redid icon mode for HiDPI, previously it was a hardcoded value: ​https://github.com/haiku/haiku/commit/509c951d8508cec41b043eab396cfa0f1fb4d3be

So long as things still look fine at standard DPI, we can change it, by all means. I agree the current spacing is probably too wide.

[khallebal]

Already reported here in #17977, one of the 2 tickets can be closed.

[zdykstra]

1600x1200, 64x64 icon, gridOffset set to 0.625f

[zdykstra]

1600x1200, 32x32 icon, gridOffset set to 0.625f

[zdykstra]

I've added two additional screenshots showing a 1600x1200 desktop, with 64x64 and 32x32 icons using a gridOffset of 0.625 - the same as the 4k screens.

Dipping the gridOffset value any lower results in the desktop attempting to layer an icon partially under the Deskbar (at it's minimum width).