Twitcher crash after change to vector icons

[madmax]

Open some apps and tap CTRL-TAB to activate the Twitcher.

vm_page_fault: vm_soft_fault returned error 'Bad address' on fault at 0x20, ip 0xc6fdeba1f0, write 0, user 1, exec 0, thread 0x5b5
debug_server: Thread 1461 entered the debugger: Segment violation
stack trace, current PC 0xc6fdeba1f0  </boot/system/lib/libbe.so> _ZNK7BBitmap6BoundsEv + 0:
  (0x7f81dc7bf050)  0xc6fdf53369  </boot/system/lib/libbe.so> _ZN5BView5_DrawE5BRect + 0xa9
  (0x7f81dc7bf080)  0xc6fdf61488  </boot/system/lib/libbe.so> _ZN7BWindow15DispatchMessageEP8BMessageP8BHandler + 0xd38
  (0x7f81dc7bf2b0)  0xc6fdf5c721  </boot/system/lib/libbe.so> _ZN7BWindow11task_looperEv + 0x1d1
  (0x7f81dc7bf340)  0xc6fde99203  </boot/system/lib/libbe.so> _ZN7BLooper7_task0_EPv + 0x23
  (0x7f81dc7bf360)  0xba3ba49b79  </boot/system/lib/libroot.so> thread_entry + 0x19

It seems it is ​asking for (and using without checking) some of the bitmap icons that were changed to vectors in hrev56911.

[korli]

Looks like a regression introduced in hrev56911, which is now reverted in hrev56921.

[jscipione]

I found the crashing line in Switcher.cpp

​https://git.haiku-os.org/haiku/tree/src/apps/deskbar/Switcher.cpp#n2289

const BBitmap* bitmap = AppResSet()->FindBitmap(B_MESSAGE_TYPE,
			minimized ? R_WindowHiddenIcon : R_WindowShownIcon);

It was crashing because Switcher was still trying to grab the old window icons which were turned into vectors behind its back. I'll upload a new patch-set to address this once I get proper window icon caching working.

[waddlesplash]

Revised change merged in hrev57017.