Web+: Large images aren't downsized-to-fit window

[humdinger]

This is hrev56578+77, 64bit. (HaikuWebKit 1.9.4)

Web+ used to downsize large images to fit in the current window. The mouse pointer became a magnifying glass and clicking the image popped the image to 100%. Click again and it got resized to fit the window again.

Can we have that back, please?

[nephele]

Was the behaviour you wanted working in 1.9.3 or has it been gone longer?

[humdinger]

It was working before I last updated Beta4. I update my Beta4 install about every two weeks.

I just remembered that there was a similar regression 1.5 years ago: #17387
Maybe a hint where to look.

[pulkomandy]

Yes, it looks like the change was lost when the file was renamed:

​​https://github.com/haiku/haikuwebkit/blob/eac2f26b8bf63caeefd16a7af0aef74adec22f06/Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml#L5949

So the same fix can be applied again.

[madmax]

The InputType*Enabled were also lost, but activating them I get an instantly disappearing calendar for dates and a color picker that crashes when a color is accepted. ShrinksStandaloneImagesToFit does work.

[nephele]

calendars were also broken before in that way iirc

[pulkomandy]

That code does not get enough testing, I had it working when I first wrote it but then not many websites use it and it probably got broken in one of the rebases. May be better to keep them disabled for now, then?

[nephele]

Yes, but probably with a ticket as a reminder to reenable them later :)

[pulkomandy]

Fixed in ​https://github.com/haiku/haikuwebkit/pull/29

Will be included in HaikuWebKit 1.9.5, I guess.