Opened 17 years ago
Closed 16 years ago
#1838 closed bug (fixed)
Horizontal scrolling is broken in BColumnListView.
Reported by: | stippi | Owned by: | anevilyak |
---|---|---|---|
Priority: | normal | Milestone: | R1/alpha1 |
Component: | Kits/Interface Kit | Version: | R1/pre-alpha1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
Additionally, the scroll area is not updated properly when removing items it seems.
Change History (13)
comment:1 by , 16 years ago
comment:2 by , 16 years ago
Owner: | changed from | to
---|
Oh yes, please do! Vertical scrolling seems to work fine. But horizontal scrolling does not affect the header view.
comment:3 by , 16 years ago
Status: | new → assigned |
---|
Will look, do you have any good app for a testcase illustrating this or will I need to write one?
comment:4 by , 16 years ago
DriveSetup can be used to reproduce it. It also builds in the test environment, in case you want to use that.
comment:6 by , 16 years ago
Actually, no. BeShare uses the column list view from Santa's Gift Bag, which has nothing in common code-wise with BColumnListView.
comment:7 by , 16 years ago
Hi stippi,
One thing that strikes me as immediately odd is that the ScrollTo hooks don't seem to be getting called....at least the printfs in said hooks aren't showing up at all.
comment:8 by , 16 years ago
Doh... just change BScrollBar::ValueChanged() to call ScrollTo() instead of ScrollBy(). That should do it. :-)
comment:10 by , 16 years ago
I feel very stupid now, because I was looking at BScrollBar::ValueChanged() _very_ often. :-)
comment:11 by , 16 years ago
If that's the case, shouldn't we modify BView::ScrollBy so it just wraps a call to the virtual version? AFAIK the virtual hook should be called in all cases, otherwise the app can't always get correct behavior, since ScrollBy is not overrideable. Replacing ScrollBy with ScrollTo in ValueChanged does indeed make BCLV behave correctly here btw.
comment:12 by , 16 years ago
Also, this would seem to imply that it is indeed also the cause of ticket #1252, though I'll need to test if that one behaves correctly with that change.
Hi stippi,
Want me to take over this one? I have some experience with the BCLV code so I'd be willing. Also, which scroll area are you referring to? Horizontal or Vertical?