[TextSearch] crash on files with long lines.

[bipolar]

Steps to reproduce:

Save a copy of ​system_logging.html locally, run > TestSearch system_logging.html, type "test" on the search input box, hit enter.

Will attach .report file next.

Could be related to #17011, but I'm not entirely sure (this one consistenly shows crash on _IO_vfscanf).

[bipolar]

Crash on beta4 32 bits

[diver]

I think trying to play a video in VLC also crashes in _IO_vfscanf.

[waddlesplash]

We should probably upgrade or replace the vfscanf implementation.

[phoudoin]

I think here it's a bug in TextSearch, in Grepper.cpp. The line buffer handed to sscanf() to extract the filename, line number and position is sized to B_PATH_NAME_LENGTH * 2. Which gives only 2048 max, AFAICT.

If the actual line read from grep output is longer than that, I fear that there is no \0 at end of the line buffer, which lead to sscanf() stepping outside memory boundary and therefore crash.

[phoudoin]

Another way to fix it is to use strtok() instead of sscanf() to parse the grep ouput lines.

[madmax]

Replying to phoudoin:

If the actual line read from grep output is longer than that, I fear that there is no \0 at end of the line buffer

The line comes from fgets, which should put the NULL at the end.

FWIW, I cannot reproduce it in hrev56931 x86_64.

[bipolar]

Replying to madmax:

FWIW, I cannot reproduce it in hrev56931 x86_64.

Indeed, it doesn't crashes on beta4 64 bits either. But does easily on beta4 32 bits.