#1867 closed bug (fixed)
Icons for other volumes default to the file cabinet icon
| Reported by: | scottmc | Owned by: | axeld |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | - General | Version: | R1/pre-alpha1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Other BFS volumes default to the file cabinet icon and so do Audio CD and I assume Data CDs would as well. See the screenshot for #1866 for example.
Change History (3)
comment:1 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 16 years ago
I would estimate that he set is Desktop icon size to something else than 16x16 or 32x32. If I read your patch correctly, you bail out early if the icon size is not one of those. This is different from the rest of the icon functions, where I check the color space of the icon. If it's 32 bit, it ignores the given icon_size and just uses the bitmap size. I can work on this today.
comment:3 by , 16 years ago
Actually, I just copied what was already there. But please remove that check; I would be all in favour of getting rid of that icon_which parameter everywhere, but for R1, I thought consistency would be the preferred way.
I am not sure what Bruno tested, but it works fine over here on different machines. Fixed in hrev27001.