Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1867 closed bug (fixed)

Icons for other volumes default to the file cabinet icon

Reported by: scottmc Owned by: axeld
Priority: normal Milestone: R1
Component: - General Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Other BFS volumes default to the file cabinet icon and so do Audio CD and I assume Data CDs would as well. See the screenshot for #1866 for example.

Change History (3)

comment:1 Changed 11 years ago by axeld

Resolution: fixed
Status: newclosed

I am not sure what Bruno tested, but it works fine over here on different machines. Fixed in hrev27001.

comment:2 Changed 11 years ago by stippi

I would estimate that he set is Desktop icon size to something else than 16x16 or 32x32. If I read your patch correctly, you bail out early if the icon size is not one of those. This is different from the rest of the icon functions, where I check the color space of the icon. If it's 32 bit, it ignores the given icon_size and just uses the bitmap size. I can work on this today.

comment:3 Changed 11 years ago by axeld

Actually, I just copied what was already there. But please remove that check; I would be all in favour of getting rid of that icon_which parameter everywhere, but for R1, I thought consistency would be the preferred way.

Note: See TracTickets for help on using tickets.