HaikuWebKit: Build issue on Haiku R1B4 x86

[cocobean]

​https://build.haiku-os.org/buildmaster/master/x86_gcc2/logviewer.html?buildruns/5456/builds/82387.log

[767/5337] Generating ../../JavaScriptCore/DerivedSources/Lexer.lut.h
FAILED: JavaScriptCore/DerivedSources/Lexer.lut.h /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/JavaScriptCore/DerivedSources/Lexer.lut.h
cd /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/Source/JavaScriptCore && /bin/perl /sources/haikuwebkit-HaikuWebKit-1.9.9/Source/JavaScriptCore/create_hash_table /sources/haikuwebkit-HaikuWebKit-1.9.9/Source/JavaScriptCore/parser/Keywords.table > /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/JavaScriptCore/DerivedSources/Lexer.lut.h

[768/5337] Generating ../../JavaScriptCore/DerivedSources/JSGlobalObject.lut.h
FAILED: JavaScriptCore/DerivedSources/JSGlobalObject.lut.h /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/JavaScriptCore/DerivedSources/JSGlobalObject.lut.h
cd /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/Source/JavaScriptCore && /bin/perl /sources/haikuwebkit-HaikuWebKit-1.9.9/Source/JavaScriptCore/create_hash_table /sources/haikuwebkit-HaikuWebKit-1.9.9/Source/JavaScriptCore/runtime/JSGlobalObject.cpp > /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/JavaScriptCore/DerivedSources/JSGlobalObject.lut.h
ninja: build stopped: subcommand failed.

Platform: Haiku hrev56578_87 x86

[pulkomandy]

There isn't any error message except that the build has failed, I'm not sure what to do with that. Is perl broken?

[korli]

The perl process might have been killed:

17:13 <waddlesplash> PulkoMandy: talking to mmlr. builder not crashed:
17:13 <waddlesplash> "same as last time, the perl generator scripts in an endless loop"
17:14 <waddlesplash> I think he said it appeared to be an issue in perl itself

[cocobean]

Seems the issue is conclusive based on the previous HaikuWebKit 1.9.8 build - ​https://build.haiku-os.org/buildmaster/master/x86_gcc2/logviewer.html?buildruns/5255/builds/82136.log

Yet, HaikuWebKit 1.9.7 was a successful build and used the same Perl package... ??

[madmax]

Fired up a VM and tried running one of those commands without the full build. It hangs.

The script Source/JavaScriptCore/create_hash_table has changed (to improve hashing performance?). Reverting ​the latest change works. I mean, the script finishes and a file is generated, I haven't checked if it contains what it should. But then I don't grok perl and I don't know why.

[pulkomandy]

Using perl-x86 doesn't help Installing the latest version of Math::BigInt also doesn't help

Our perl is from 2021, maybe we should update it?

[madmax]

For whatever is worth, the loop is due to the hash function returning the same small value for several items (function, implements and interface in the keywords table case), and that happens because for: $value = ($value & $mask32), where $mask32 is 2³² - 1 and $value > 2³², the result is what you'd expect with bigint but is 2³² - 1 with Math::BigInt.

[pulkomandy]

It seems the bug is not only on Haiku and there is a fix in WebKit already:

​https://bugs.webkit.org/show_bug.cgi?id=265554

I will update our branch to include this.