Opened 11 months ago
Closed 2 months ago
#18698 closed bug (fixed)
HaikuWebKit: Build issue on Haiku R1B4 x86
Reported by: | cocobean | Owned by: | pulkomandy |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Kits/Web Kit | Version: | R1/beta4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | x86 |
Description
[767/5337] Generating ../../JavaScriptCore/DerivedSources/Lexer.lut.h FAILED: JavaScriptCore/DerivedSources/Lexer.lut.h /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/JavaScriptCore/DerivedSources/Lexer.lut.h cd /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/Source/JavaScriptCore && /bin/perl /sources/haikuwebkit-HaikuWebKit-1.9.9/Source/JavaScriptCore/create_hash_table /sources/haikuwebkit-HaikuWebKit-1.9.9/Source/JavaScriptCore/parser/Keywords.table > /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/JavaScriptCore/DerivedSources/Lexer.lut.h [768/5337] Generating ../../JavaScriptCore/DerivedSources/JSGlobalObject.lut.h FAILED: JavaScriptCore/DerivedSources/JSGlobalObject.lut.h /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/JavaScriptCore/DerivedSources/JSGlobalObject.lut.h cd /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/Source/JavaScriptCore && /bin/perl /sources/haikuwebkit-HaikuWebKit-1.9.9/Source/JavaScriptCore/create_hash_table /sources/haikuwebkit-HaikuWebKit-1.9.9/Source/JavaScriptCore/runtime/JSGlobalObject.cpp > /sources/haikuwebkit-HaikuWebKit-1.9.9/WebKitBuild/Release/JavaScriptCore/DerivedSources/JSGlobalObject.lut.h ninja: build stopped: subcommand failed.
Platform: Haiku hrev56578_87 x86
Change History (10)
comment:1 by , 11 months ago
Component: | Applications/WebPositive → Kits/Web Kit |
---|---|
Keywords: | haikuwebkit removed |
comment:2 by , 11 months ago
comment:3 by , 11 months ago
The perl process might have been killed:
17:13 <waddlesplash> PulkoMandy: talking to mmlr. builder not crashed: 17:13 <waddlesplash> "same as last time, the perl generator scripts in an endless loop" 17:14 <waddlesplash> I think he said it appeared to be an issue in perl itself
comment:4 by , 11 months ago
Seems the issue is conclusive based on the previous HaikuWebKit 1.9.8 build - https://build.haiku-os.org/buildmaster/master/x86_gcc2/logviewer.html?buildruns/5255/builds/82136.log
Yet, HaikuWebKit 1.9.7 was a successful build and used the same Perl package... ??
comment:5 by , 11 months ago
Fired up a VM and tried running one of those commands without the full build. It hangs.
The script Source/JavaScriptCore/create_hash_table has changed (to improve hashing performance?). Reverting the latest change works. I mean, the script finishes and a file is generated, I haven't checked if it contains what it should. But then I don't grok perl and I don't know why.
comment:6 by , 11 months ago
Using perl-x86 doesn't help Installing the latest version of Math::BigInt also doesn't help
Our perl is from 2021, maybe we should update it?
comment:7 by , 11 months ago
For whatever is worth, the loop is due to the hash function returning the same small value for several items (function, implements and interface in the keywords table case), and that happens because for:
$value = ($value & $mask32)
, where $mask32 is 232 - 1 and $value > 232, the result is what you'd expect with bigint but is 232 - 1 with Math::BigInt.
comment:8 by , 11 months ago
It seems the bug is not only on Haiku and there is a fix in WebKit already:
https://bugs.webkit.org/show_bug.cgi?id=265554
I will update our branch to include this.
comment:9 by , 2 months ago
Resolved!!! Haikuwebkit 1.9.14-1 built on haiku-r1~beta5_hrev57937_5-1-x86-TC0
.
Confirmed that WebPositive still works on Haiku x86.
Please close this ticket.
comment:10 by , 2 months ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
There isn't any error message except that the build has failed, I'm not sure what to do with that. Is perl broken?