NetworkStatus: wifi network list regression

[korli]

I updated to hrev57560. Now the wireless menu isn't listed sorted by signal strength like before.

[waddlesplash]

Presumably a regression from hrev57533.

[madmax]

The compare functions for std::stable_sort and BList are different. Instead of the typical signed value to know if a is less than, equal to or greater than b, stable_sort just reads a boolean saying whether a < b. Changing CompareSignalStrength to return bStrength < aStrength (and strncasecmp < 0) seems to work, but maybe the signature should also be changed?

[korli]

Indeed signature should be: bool cmp(const Type1& a, const Type2& b);

[pulkomandy]

We can change it but then it isn't quite compatible with the previous API. Is that acceptable? I guess so, if the function did not yet get too much use in existing software.

[korli]

Patch without signature change: ​https://review.haiku-os.org/c/haiku/+/7401

[korli]

Merged in hrev57581. Thanks Madmax for the pointer!