Bug in KeyStore api documentation (easy)

[ilzu]

In KeyStore API documentation (​https://www.haiku-os.org/docs/api/classBKeyStore.html , ​https://git.haiku-os.org/haiku/tree/docs/user/app/KeyStore.dox) it is said in multiple variants of GetKey -function that "This is a convenience method that calls GetKey(const char* keyring, BKeyType type, const char* identifier, const char* secondaryIdentifier, bool secondaryIdentifierOptional, BKey& key). It sets secondaryIdentifierOptional to false, meaning it both identifiers are required to match."

But in the source code (​https://git.haiku-os.org/haiku/tree/src/kits/app/KeyStore.cpp), in all cases I looked for, those functions set the secondaryIdentifierOptional to true, which is opposite to what the documentation says.

[ilzu]

Personally I think it is a bug in the code, as the logic seems more correct on the documentation. Which one should be fixed, the logic of the code or the documentation?

[pulkomandy]

I looked in the commit log to see if there was a reason for it being this way, but didn't find anything. So, yes, changing the code to match the documentation would also be fine.

[ilzu]

I've pushed a fix for this for review. ​https://review.haiku-os.org/c/haiku/+/7398

[pulkomandy]

Merged in hrev57580