[GLIFE] minor bugs

[tzu_mi]

Hi, there are some minor bugs in GLife screensaver:

• there is too much room in the upper part of the view, and two sliders in the bottom, so it looks odd;
• some strings aren't translated correctly, even if there are, apparently, in the catkeys (the attached screenshot is in catalan, but it happens in other localizations too).

[nephele]

Could you elaborate? I don't see any bug in those screenshots.

[tzu_mi]

As you can see in the first attachment "Grid life delay:" is translated, in the second one it is not when it's followed by the multiplier, even if in the catkeys it's translated correctly, the same happens with every localization, the german one is going to be attached too.

I think that the upper extra room in the settings view appears just odd, probably it is aligned to the bottom

[nephele]

Relevant code:

---

src/add-ons/screen_savers/glife/GLifeConfig.cpp

    if (delay <= 0)
        newLabel = B_TRANSLATE("Grid life delay: none");
    else {
        newLabel.SetToFormat(B_TRANSLATE_CONTEXT("Grid life delay: "
            "%" B_PRId32 "x", "This is a factor: the x represents 'times', "
            "don't translate '%" B_PRId32"'"), delay);
    }

---

It looks correct to me

(it could be reformated with 100 lines, and use unicode multiplication sign)

What haiku revision are you encountering this on?

[tzu_mi]

I've just updated to hrev 57633

[madmax]

That B_PRId32 has a different value in x86 and x86_64. I don't know how the catalog extraction works, but there's just one string in it, and that's for the 32 bits version. So it find the translation in 32 bits and does not in 64.

[waddlesplash]

Indeed, B_PRI can't be used in translation strings directly.

[nephele]

delay is of type int32, I‘ll reformat this.

Thanks for the hint :)

[Starcrasher]

Something wrong is that you shouldn't be allowed to resize the window and cut scales like in screenshot2, moreover if it hides a slider.

Indeed using a bit of the free space above to put one slider per line would be a good idea. And perhaps not make sliders using the full width to have a small margin.

[nephele]

fix: ​https://review.haiku-os.org/c/haiku/+/7518

[nephele]

I don't think switching the slider position makes sense. All the other screensavers do it in the same way.

[mt]

I think this code may help for newLabel formatting.

​https://cgit.haiku-os.org/haiku/tree/src/servers/print/ConfigWindow.cpp#n529