Should restore default window position when it starts out of screen (easy)

[slema]

I changed my desktop from 4k to 1080 at some point. As a result the position for Icon-O-Matic kept opening out of screen. Visually I saw nothing. When I opened it from filetypes nothing happened apparently as it was indeed visible but outside of screen bounds.

I believe that if on app startup the window to be restored is out of maximum visible area the default size should be restored (this is what I did manually by going into the settings and deleting the settings file for icon-o-matic before restarting it).

[Zardshard]

This looks like it would make a good easy ticket.

Hint to whoever decides to take this up: figure out a way to get the screen's size, perhaps through BScreen::GetMode, and take that into account when updating fLastWindowFrame in IconEditorApp.cpp.

[waddlesplash]

I think just a call to MoveOnScreen() should suffice?

[Zardshard]

Ah, wasn't aware of that API. That should make it easier. You may need to update fLastWindowFrame after calling it.

[Zardshard]

Can this be marked as easy?

[boody]

Could you please tell me how to reproduce this issue? I've been changing the resolution of the screen and nothing happens

[pulkomandy]

• Set your screen to a large resolution
• Open Icon-O-Matic
• Move the window to somewhere in the bottom right of the screen (maybe mostly offscreen with just a bit of the titlebar visible)
• Close Icon-O-Matic
• Switch to a low resolution
• Open Icon-O-Matic again

It will remember its latest position, if you put it far enough to the bottom or right, it will not be in the visible part of the screen anymore.

[boody]

I think I got it you want it to open as you open it for the first time

[boody]

But what this got to do with the resolution? It remembers its position wether you change the resolution or not

[pulkomandy]

Yes, but when you change to a smaller resolution, the previous position can end up being out of the screen. In this case, the window should be moved so it is back into the visible part of the screen, so users are not confused by an apparently invisible and unreachable window.

[boody]

I understand this issue. I mean the solution to this issue has nothing to do with the resolution. Is that true?

[nephele]

You need to check if the window position it wants to restore is valid, that is visible in the currently configured screen area. If it is not don‘t restore the window position and instead adopt a default window position.

[humdinger]

Wouldn't a simple MoveOnScreen() when creating the window solve the issue?

[pulkomandy]

Yes, as Waddlesplash already commented 3 months ago, the MoveOnScreen() function already takes care of all the details. Just call it at the right place.

[humdinger]

Oops, didn't read that far back... :)

[nephele]

boody has prosuced a fix: ​https://review.haiku-os.org/c/haiku/+/7788

[waddlesplash]

Merged in hrev57775.