Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#199 closed bug (fixed)

[Terminal] Find feature is missing

Reported by: diver Owned by: Niels.Reedijk@…
Priority: normal Milestone: R1
Component: Applications Version:
Keywords: Cc: Niels.Reedijk@…
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Find feature in Terminal is missing

Attachments (5)

slider.PNG (9.7 KB ) - added by jackburton 13 years ago.
Missing slider invalidation
199-1.patch (8.6 KB ) - added by Niels.Reedijk@… 13 years ago.
GUI portion of the patch
199-2.patch (13.1 KB ) - added by Niels.Reedijk@… 13 years ago.
Updated GUI patch
199-3.patch (19.6 KB ) - added by Niels.Reedijk@… 13 years ago.
Final (?) patch
199-4.patch (20.4 KB ) - added by Niels.Reedijk@… 13 years ago.
Second final attempt

Download all attachments as: .zip

Change History (24)

comment:1 by axeld, 14 years ago

Owner: changed from sikosis to axeld

comment:2 by korli, 13 years ago

bug_group: developers

comment:3 by diver, 13 years ago

Summary: Find feature in Terminal is missing[Terminal] Find feature is missing

comment:4 by diver, 13 years ago

(In reply to comment #1)

Created an attachment (id=265) [edit] Missing slider invalidation

I guess you meant this attach for #193, right? ;-)

comment:5 by jackburton, 13 years ago

ARGH Sorry :)

comment:6 by jackburton, 13 years ago

attachments.isobsolete: 01

by jackburton, 13 years ago

Attachment: slider.PNG added

Missing slider invalidation

comment:7 by Niels.Reedijk@…, 13 years ago

Cc: stefano.ceccherini@… added

comment:8 by Niels.Reedijk@…, 13 years ago

I'm going to try this one. Stefano, CC'ing you for review.

comment:9 by jackburton, 13 years ago

Looks good, except for some style issues I already told you about on irc. At least it doesn't do any harm :)

by Niels.Reedijk@…, 13 years ago

Attachment: 199-1.patch added

GUI portion of the patch

comment:10 by Niels.Reedijk@…, 13 years ago

attachments.isobsolete: 01

comment:11 by Niels.Reedijk@…, 13 years ago

Cc: Niels.Reedijk@… added

by Niels.Reedijk@…, 13 years ago

Attachment: 199-2.patch added

Updated GUI patch

comment:12 by jackburton, 13 years ago

Owner: changed from axeld to Niels.Reedijk@…

comment:13 by Niels.Reedijk@…, 13 years ago

Status: newassigned

comment:14 by Niels.Reedijk@…, 13 years ago

attachments.isobsolete: 01

comment:15 by Niels.Reedijk@…, 13 years ago

Saw one thing I'll correct: the UseHeaders [ FDirName $(HAIKU_TOP) src kits tracker ] ; line in the Jamfile is unnecessary and was for testing purposes. I'll revert that one.

Other note: R5's terminal includes a regexp search. I did not implement that, due to the fact that it would make the code a lot more complicated. Perhaps if BString is extended to do regexp searches. If it is important to add it, it deserves its own bug.

comment:16 by Niels.Reedijk@…, 13 years ago

attachments.isobsolete: 01

by Niels.Reedijk@…, 13 years ago

Attachment: 199-3.patch added

Final (?) patch

by Niels.Reedijk@…, 13 years ago

Attachment: 199-4.patch added

Second final attempt

comment:17 by Niels.Reedijk@…, 13 years ago

Sending terminal/Changelog Deleting terminal/Constants.h Sending terminal/FindDlg.cpp Sending terminal/FindDlg.h Sending terminal/Jamfile Sending terminal/TermBuffer.cpp Sending terminal/TermBuffer.h Sending terminal/TermConst.h Sending terminal/TermView.cpp Sending terminal/TermView.h Sending terminal/TermWindow.cpp Sending terminal/TermWindow.h Transmitting file data ........... Committed revision 18561.

comment:18 by Niels.Reedijk@…, 13 years ago

Resolution: fixed

comment:19 by Niels.Reedijk@…, 13 years ago

Status: assignedclosed
Note: See TracTickets for help on using tickets.