Opened 17 years ago
Closed 17 years ago
#2034 closed bug (fixed)
Can't unpackage zip files with short filenames
| Reported by: | scottmc | Owned by: | korli |
|---|---|---|---|
| Priority: | normal | Milestone: | R1/alpha1 |
| Component: | Applications/Expander | Version: | R1/pre-alpha1 |
| Keywords: | Cc: | j_freeman | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Tried unzipping jam.zip won't go, but if you rename it to jam2.zip it will. So I tried a few other zip files and it seems 3 letters is no-go but 4 is fine.
Attachments (2)
Change History (7)
by , 17 years ago
| Attachment: | zip-short-name.png added |
|---|
comment:1 by , 17 years ago
| Component: | - General → Applications/Expander |
|---|---|
| Milestone: | R1 → R1/alpha1 |
| Owner: | changed from to |
comment:2 by , 17 years ago
| Cc: | added |
|---|
by , 17 years ago
| Attachment: | ExpanderRules_Ticket2034.diff added |
|---|
Problem was ExpanderRules::MatchingRule(..) which can return a false rule if the extension does not match (-1) and the extension-position is calculated as -1, too. Please review!
comment:3 by , 17 years ago
While I can't say anything about the patch, I think Expander shouldn't depends totally on the naming (extension). It'd be nice to have something that behaves like "file" and figure out the type of file, then expand it with the appropriate method. Of course though, extension should have the priority.
comment:4 by , 17 years ago
Well, Expander actually checks for matching MIME-types. The (additional) check for the file-extension was broken though.
Good catch!