Opened 11 years ago

Closed 11 years ago

#2200 closed bug (invalid)

BMimeType::GetIcon() can't get vector icon

Reported by: shinta Owned by: stippi
Priority: normal Milestone: R1
Component: Kits/Storage Kit Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: x86

Description

BNodeInfo::GetIcon() can get vector icon by passing B_RGBA32 BBitmap, but, BMimeType::GetIcon() can't get.

Haiku: hrev25124+ SHINTA

Attachments (1)

database_access.diff (809 bytes ) - added by shinta 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by stippi, 11 years ago

Owner: changed from axeld to stippi
Status: newassigned

I'm afraid you will need to get more specific. If BMimeType::GetIcon() was generally broken, most icons in Tracker would not be visible. Particularily, BMimeType::GetIcon() is based on BNode like BNodeInfo. Please describe your particular situation in more detail. Thanks!

comment:2 by shinta, 11 years ago

Sorry! It was my misunderstanding! BMimeType::GetIcon() works well.

By the way, why doesn't database_access.cpp's get_icon() use BIconUtils::GetIcon() such as the attached file? Sorry, I couldn't test the code because "jam -q" in src/kits/storage didn't work.

by shinta, 11 years ago

Attachment: database_access.diff added

comment:3 by stippi, 11 years ago

A mime database entry may specify several icons. Especially application entries may specify the icon of the application, plus one or more icons for associated files. Your code would only retrieve the application icon, since it ignores the "const char* fileType" parameter. As far as I am aware, every code that deals with icons, uses BIconUtils sooner or later.

comment:4 by shinta, 11 years ago

Thank you for explaining!

comment:5 by stippi, 11 years ago

Resolution: invalid
Status: assignedclosed

No problem at all! I am closing this as invalid then. I hope this conclusion is correct. Please just reopen if I misunderstood and there is a problem still left.

Note: See TracTickets for help on using tickets.