Input method draws converting strings dirty

[shinta]

Input methods (IM) like Canna IM draws converting strings (bgcolor = pink, blue) dirty. See the attached picture. I guess that BView's low color (view color?) is set to white, although should be set to pink, blue.

Haiku: hrev25124+ ​SHINTA

[shinta]

I think string should be drawn separately (blue/red region) like attached patch. But, the patch has a bug on line breaking.

[shinta]

I rewrited patch.

TextView.diff should fix this problem.

[axeld]

Thanks! I'll assign this to Stefano for review, as he is our BTextView master :-)

[stippi]

I have reviewed the patch and it looks fine to me. However, as I understand, all this is supposed to do is fix the bad text anti-aliasing. The patch adds considerable overhead just to be able to use B_OP_COPY text rendering (the only text rendering where the low color of the view is used regardless of the true background of the text). While B_OP_COPY rendering is indeed much faster, the added client-server communication in this patch should completely ruin any speed gains. Therefor, I would vote to keep the original code and simply add a view->SetDrawingMode(B_OP_OVER) before rendering the inputted text in order to make the text blend with the true background. This also makes the code easier to read, understand and extend.

[stippi]

Oh, forgot to mention... there are a couple of issues with the patch as is: The drawing view is not used consistently, so with double buffered drawing, it would not work. And the added private function has a typo in it's name.

[stippi]

Alternative fix

[stippi]

SHINTA, could you have a look at my "Alternative Fix" patch? Does that solve the observed problem as well?

[shinta]

stippi, your patch works well. It's simple!

Thank you.

[stippi]

Thanks for the feedback (was unable to test). Thus fixed in hrev25349.