Opened 11 years ago

Closed 11 years ago

#2210 closed enhancement (fixed)

[PATCH] Followup of ticket 2170 : Revert button now works for timezones too

Reported by: stpere Owned by: stippi
Priority: normal Milestone: R1
Component: Preferences/Time & Date Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This enhancement is a followup of ticket 2170 :

Following suggestion from Stephan, I've enhanced the revert feature of the Time preflets.

  1. Clicking the revert button now also revert the timezone.
  2. I have moved the revert button to the BaseView (below the tabs)
  3. Since that on the default vmware-image (at least on my setup), there are no timezone link and this seems to confuse the preflet (it shows no text in the rolldown menu and the city list is empty), now, it assumes the Greenwich meridian time and shows it in the "Others" area.

Note: I've encountered a crash once when reverting, but have not been capable to reproduce it. I've tried all the combinations I could think of (default to random timezone, then revert; random timezone to random timezone, then revert; etc...) and it seems to work ok.

Note 2: I'm a bit confused by the desired behaviour or the localtime/gmt radio button in datetime panel. Could someone confirms it's ok?

Attachments (1)

RevertTimezone.diff (12.8 KB) - added by stpere 11 years ago.
Add revert feature for the timezones in Time Preflet (with bugfix)

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by stpere

Attachment: RevertTimezone.diff added

Add revert feature for the timezones in Time Preflet (with bugfix)

comment:1 Changed 11 years ago by stippi

Owner: changed from axeld to stippi
Status: newassigned

Working on it.

comment:2 Changed 11 years ago by stippi

Resolution: fixed
Status: assignedclosed

Applied in hrev25415. Nice work, thanks a lot and sorry for the delay!

Note: See TracTickets for help on using tickets.