Opened 11 years ago

Closed 11 years ago

#2215 closed bug (invalid)

Terminal as replicant doesn't respect settings

Reported by: scottmc Owned by: jackburton
Priority: normal Milestone: R1
Component: Applications/Terminal Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

To duplicate, change the color settings of the terminal, and then drag it out as a replicant, you then see your colors go back to black on white. I think this was in hrev25374

Change History (7)

comment:1 Changed 11 years ago by jackburton

All settings are ignored when terminal is a replicant. This happens because settings are saved/loaded at the window level, not at the TermView level.

This was done because I thought one could want to use different settings when embedding the TermView either directly or via replicant. But maybe this wasn't a good idea... maybe I should move settings again into TermView. Thoughts ?

comment:2 Changed 11 years ago by axeld

Component: - GeneralApplications/Terminal
Owner: changed from axeld to jackburton

For the ActivityMonitor, I used the following method: usually, it reads its settings in the window class, puts it into a message, and passes this one to the ActivityView. When archiving the ActivityView, it would remember these settings, and store it in its own message. That way, it takes over the current settings at the time the replicant was initialized, but still allows its own settings afterwards.

In any case, as stippi mentioned, the replicant must include the scrollview to be of use, so there needs to be some sort of shell anyway.

comment:3 in reply to:  2 Changed 11 years ago by jackburton

Replying to axeld:

For the ActivityMonitor, I used the following method: usually, it reads its settings in the window class, puts it into a message, and passes this one to the ActivityView. When archiving the ActivityView, it would remember these settings, and store it in its own message. That way, it takes over the current settings at the time the replicant was initialized, but still allows its own settings afterwards.

Ok, thanks, I'll have a look at what you did in ActivityView.

In any case, as stippi mentioned, the replicant must include the scrollview to be of use, so there needs to be some sort of shell anyway.

To fix this problem, the TermView itself could include the scrollbar... I haven't put much thinking on this yet, though.

comment:4 Changed 11 years ago by scottmc

Bonus points if you can also allow transparentcy. ;)

comment:5 Changed 11 years ago by jackburton

Summary: Terminal colors as replicant goto black on white even if selected otherwiseTerminal as replicant doesn't respect settings

comment:6 Changed 11 years ago by scottmc

Seeing as the replicant feature has been removed from terminal, this ticket can also be closed.

comment:7 Changed 11 years ago by axeld

Resolution: invalid
Status: newclosed

Thanks for the note.

Note: See TracTickets for help on using tickets.