#2218 closed enhancement (fixed)
Key binding for turning on/off inputh methods (IM)
Reported by: | shinta | Owned by: | korli |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Servers/input_server | Version: | R1/pre-alpha1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | x86 |
Description
Currently, key binding for turning on/off input methods (switching Roman <--> (Japanese) input methods) is "Alt+Space" or "Alt+Zenkaku/Hankaku". (FYI: Zenkaku/Hankaku is a key which Japanese keyboard has.)
Alt+Space is good.
Alt+Zenkaku/Hankaku is required to change in Japanese community. Please no-midifiers Zenkaku/Hankaku, not Alt+Zenkaku/Hankaku. Currently, Zenkaku/Hankaku itself has no function, so, it is reasonable to make no-modifiers Zenkaku/Hankaku turn on/off.
Actually, old versions of Windows used Alt+Zenkaku/Hankaku to turn on/off input methods, but, current version of Windows uses no-modifiers Zenkaku/Hankaku.
cf: JPBE.net IM relative forum thread http://www.jpbe.net/forum/viewtopic.php?p=7763#7763
Attachments (1)
Change History (8)
comment:1 by , 17 years ago
Cc: | added |
---|
by , 17 years ago
Attachment: | InputServer.diff added |
---|
comment:5 by , 17 years ago
Thank you.
But, a bit difference.
not
if ((fKeyInfo.modifiers & B_COMMAND_KEY) != 0 && (byte == ' ' || static_cast<uint8>(byte) == B_ZENKAKU_HANKAKU)) {
but
if ((fKeyInfo.modifiers & B_COMMAND_KEY) != 0 && byte == ' ' || static_cast<uint8>(byte) == B_ZENKAKU_HANKAKU) {
because B_ZENKAKU_HANKAKU doesn't need B_COMMAND_KEY.
comment:6 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Applied in hrev25421. It's better to explicitly use parenthesis for such comparisons :)
SHINTA-san,
Can you provide a patch to attain the desired change? If you can, please provide one as an attachment.