Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#2218 closed enhancement (fixed)

Key binding for turning on/off inputh methods (IM)

Reported by: shinta Owned by: korli
Priority: normal Milestone: R1
Component: Servers/input_server Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Platform: x86


Currently, key binding for turning on/off input methods (switching Roman <--> (Japanese) input methods) is "Alt+Space" or "Alt+Zenkaku/Hankaku". (FYI: Zenkaku/Hankaku is a key which Japanese keyboard has.)

Alt+Space is good.

Alt+Zenkaku/Hankaku is required to change in Japanese community. Please no-midifiers Zenkaku/Hankaku, not Alt+Zenkaku/Hankaku. Currently, Zenkaku/Hankaku itself has no function, so, it is reasonable to make no-modifiers Zenkaku/Hankaku turn on/off.

Actually, old versions of Windows used Alt+Zenkaku/Hankaku to turn on/off input methods, but, current version of Windows uses no-modifiers Zenkaku/Hankaku.

cf: IM relative forum thread

Haiku: hrev25124+ SHINTA (enhancement No.2)

Attachments (1)

InputServer.diff (764 bytes ) - added by shinta 15 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by koki, 15 years ago

Cc: koki added


Can you provide a patch to attain the desired change? If you can, please provide one as an attachment.

comment:2 by shinta, 15 years ago

I'll try.

by shinta, 15 years ago

Attachment: InputServer.diff added

comment:3 by shinta, 15 years ago

This patch and patch for #2222 (hrev25413) realize this enhancement.

comment:4 by korli, 15 years ago

I applied in hrev25416. Could you confirm please ?

comment:5 by shinta, 15 years ago

Thank you.

But, a bit difference.


if ((fKeyInfo.modifiers & B_COMMAND_KEY) != 0
&& (byte == ' ' || static_cast<uint8>(byte) == B_ZENKAKU_HANKAKU)) {


if ((fKeyInfo.modifiers & B_COMMAND_KEY) != 0
&& byte == ' ' || static_cast<uint8>(byte) == B_ZENKAKU_HANKAKU) {

because B_ZENKAKU_HANKAKU doesn't need B_COMMAND_KEY.

comment:6 by korli, 15 years ago

Resolution: fixed
Status: newclosed

Applied in hrev25421. It's better to explicitly use parenthesis for such comparisons :)

comment:7 by shinta, 15 years ago

Thank you :)

Note: See TracTickets for help on using tickets.