Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#2218 closed enhancement (fixed)

Key binding for turning on/off inputh methods (IM)

Reported by: shinta Owned by: korli
Priority: normal Milestone: R1
Component: Servers/input_server Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: x86

Description

Currently, key binding for turning on/off input methods (switching Roman <--> (Japanese) input methods) is "Alt+Space" or "Alt+Zenkaku/Hankaku". (FYI: Zenkaku/Hankaku is a key which Japanese keyboard has.)

Alt+Space is good.

Alt+Zenkaku/Hankaku is required to change in Japanese community. Please no-midifiers Zenkaku/Hankaku, not Alt+Zenkaku/Hankaku. Currently, Zenkaku/Hankaku itself has no function, so, it is reasonable to make no-modifiers Zenkaku/Hankaku turn on/off.

Actually, old versions of Windows used Alt+Zenkaku/Hankaku to turn on/off input methods, but, current version of Windows uses no-modifiers Zenkaku/Hankaku.

cf: JPBE.net IM relative forum thread http://www.jpbe.net/forum/viewtopic.php?p=7763#7763

Haiku: hrev25124+ SHINTA (enhancement No.2)

Attachments (1)

InputServer.diff (764 bytes) - added by shinta 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by koki

Cc: koki added

SHINTA-san,

Can you provide a patch to attain the desired change? If you can, please provide one as an attachment.

comment:2 Changed 11 years ago by shinta

I'll try.

Changed 11 years ago by shinta

Attachment: InputServer.diff added

comment:3 Changed 11 years ago by shinta

This patch and patch for #2222 (hrev25413) realize this enhancement.

comment:4 Changed 11 years ago by korli

I applied in hrev25416. Could you confirm please ?

comment:5 Changed 11 years ago by shinta

Thank you.

But, a bit difference.

not

if ((fKeyInfo.modifiers & B_COMMAND_KEY) != 0
&& (byte == ' ' || static_cast<uint8>(byte) == B_ZENKAKU_HANKAKU)) {

but

if ((fKeyInfo.modifiers & B_COMMAND_KEY) != 0
&& byte == ' ' || static_cast<uint8>(byte) == B_ZENKAKU_HANKAKU) {

because B_ZENKAKU_HANKAKU doesn't need B_COMMAND_KEY.

comment:6 Changed 11 years ago by korli

Resolution: fixed
Status: newclosed

Applied in hrev25421. It's better to explicitly use parenthesis for such comparisons :)

comment:7 Changed 11 years ago by shinta

Thank you :)

Note: See TracTickets for help on using tickets.