Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#2222 closed bug (fixed)

Zenkaku/Hankaku key code in Japanese keymap

Reported by: shinta Owned by: korli
Priority: normal Milestone: R1
Component: Servers/input_server Version: R1/pre-alpha1
Keywords: Cc: shinta.0806@…
Blocked By: Blocking:
Has a Patch: no Platform: x86

Description

Zenkaku/Hankaku key code isn't defined in Japanese keymap. Current key code seem to be space.

Haiku: hrev25124+ SHINTA (bug No.18)

Attachments (2)

Japanese.keymap.diff (1.7 KB ) - added by shinta 11 years ago.
zenhan.diff (924 bytes ) - added by shinta 10 years ago.

Download all attachments as: .zip

Change History (13)

by shinta, 11 years ago

Attachment: Japanese.keymap.diff added

comment:1 by shinta, 11 years ago

Attached patch changes two key codes: Zenkaku/Hankaky key and Katakana/Hiragana key.

Japanese specific key codes are below:

Key name          Scan     Windows'      Windows'
                   code(?)  constants     virtual key code
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Zenkaku/Hankaku   0x11     VK_OEM_AUTO   0xf3
Katakana/Hiragana 0x6e     VK_OEM_COPY   0xf2
Henkan            0x6d     VK_CONVERT    0x1c
Muhenkan          0x6c     VK_NONCONVERT 0x1d

(cf. http://lldev.jp/hsp/script/h_virtual_key.html)

I didn't change the key codes of Henkan and Muhenkan because their key codes are already used by arrow keys.

I tested this patch at my Japanese keyboard "Owltech OWL-KB108PA".

comment:2 by stippi, 11 years ago

Ok, I applied the keycodes diff in hrev25413. I suppose that's not all to make it work though, is it? Thanks so far!

comment:3 by shinta, 11 years ago

I think about other two key codes later because I don't face problems yet.

Thank you.

comment:4 by korli, 11 years ago

I'm wondering in which code 0xf3 and 0xf2 are supposed to be used ? We might want to reserve these codes in InterfaceDefs.h

comment:5 by shinta, 11 years ago

I used 0xf2/0xf3 which is same as Windows' value. I think that Microsoft selected these value because these value seem to be rarely conflict other key codes.

It maybe better to add B_ZENKAKU_HANKAKU and B_KATAKANA_HIRAGANA to InterfaceDefs.h.

comment:6 by korli, 11 years ago

Resolution: fixed
Status: newclosed

by shinta, 10 years ago

Attachment: zenhan.diff added

comment:7 by shinta, 10 years ago

Resolution: fixed
Status: closedreopened

Sorry, I mistook the key name. Not B_ZENKAKU_HANKAKU, but B_HANKAKU_ZENKAKU.

comment:8 by shinta, 10 years ago

Above zenhan.diff fixes the name.

comment:9 by stippi, 10 years ago

Resolution: fixed
Status: reopenedclosed

Fixed in hrev30599. Thanks a lot!

comment:10 by shinta, 10 years ago

Cc: shinta.0806@… added

comment:11 by shinta, 10 years ago

Thanks for committing!

Note: See TracTickets for help on using tickets.