Opened 11 years ago

Closed 11 years ago

#2370 closed bug (fixed)

[Screen] "Do you wish to keep these settings" isn't font sensetive (easy)

Reported by: diver Owned by: axeld
Priority: normal Milestone: R1
Component: Preferences/Screen Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

"Do you wish to keep these settings" window either isn't font sensetive or just lacks alert icon. Tested with hrev25926 under vmware. See screenshot.

Attachments (3)

screen.png (88.8 KB) - added by diver 11 years ago.
screen_alert_icon.patch (1.4 KB) - added by thebolt 11 years ago.
media_alert_icon.patch (1.2 KB) - added by thebolt 11 years ago.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by diver

Attachment: screen.png added

comment:1 Changed 11 years ago by diver

Summary: [Screen] "Do you wish to keep these settings" isn't font sensetive[Screen] "Do you wish to keep these settings" isn't font sensetive (easy)

Changed 11 years ago by thebolt

Attachment: screen_alert_icon.patch added

Changed 11 years ago by thebolt

Attachment: media_alert_icon.patch added

comment:2 Changed 11 years ago by thebolt

Attached a patch that fix the problem of the missing warn icon and also a patch that fix the same problem in Preferences/Media.

comment:3 Changed 11 years ago by diver

Could someone take a look at this patch please?

comment:4 Changed 11 years ago by axeld

Status: newassigned

comment:5 Changed 11 years ago by axeld

Resolution: fixed
Status: assignedclosed

Thanks, I've applied your patch in hrev26978. I just made a few changes: use B_RGBA32 for icons instead of B_CMAP8, and honour the 80 column line limit.

Note: See TracTickets for help on using tickets.