[Interface kit] enlarging menus

[diver]

• Open /boot/beos/system/add-ons/Translators/TIFFTranslator.
• Set "Use compression" option to anything else from default.
• Notice menu width enlarging.

[jackburton]

For some reason, calling BMenuField::ResizeToPreferred() (it's called every time the user changes selection) does this. Needs some investigation.

[jackburton]

(In #3051) I'm sure this is a dup of #2413.

[chico]

enlarge the menu

[chico]

Ticket #2413 is enlarging MenuField. There are two solution to fix this bug. One is set :

 fCompressionMF = new BMenuField(BRect(20, 50, 215, 70), "compression",
                                    "Use Compression:", menu,
                                    true,B_FOLLOW_LEFT_RIGHT);
//    fCompressionMF->ResizeToPreferred();

the menufield is always to the View's right. The diff is in the attachment.

Another solution is: the menufield side is not to the view's right, and its width is equal to the characters.

fCompressionMF = new BMenuField(BRect(20, 50, 215, 70), "compression",
                                    "Use Compression:", menu,
                                    false);

So which solution should we choose? And I don't know I fixed the bug or not. I also found the menufield of sgi translator is the same.

[stippi]

Both of these solutions just fix a symptom of a bug in the class framework of BMenu <-> BMenuBar <-> _BMCPrivate_ (the BMenuBar subclass used in the BMenuField control). If the BMenu has a certain resizing mode (B_FOLLOW_LEFT_RIGHT), then the minimum size calculation is buggy. The size calculation is different for some (BeOS-) backwards compatibility reasons, but either BMenuField should not use it at all (always layout it's BMenuBar in FrameResized()) or the calculation is simply buggy and can be fixed. In any case, this bug should not have been marked "easy", since it requires a good overview of the involved classes as well as some knowledge how to approach the backwards-compatibility requirement and test it correctly across a number of apps. Sorry.

[jackburton]

(In #5023) dup of #2413

[diver]

Still here in hrev35569.

[tbe]

In hrev35914, this still happens in Data Translations -> SGI images, and for the menu field at the top of the Backgrounds preflet.

[diver]

Can't reproduce it using TIFFTranslator, but I still can using Backgrounds preflet from #5023 in hrev38300.

[diver]

Still here in hrev44512.

[jscipione]

(In #9796) Quasi-duplicate of #2413

[jscipione]

Fixed in hrev45725 specifically 6da3c1c