Opened 11 years ago

Closed 3 weeks ago

#2417 closed enhancement (fixed)

New Trac does not allow to cc by username

Reported by: andreasf Owned by: haiku-web
Priority: normal Milestone:
Component: Website/Trac Version:
Keywords: Cc: niels.reedijk@…, andreasf
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

The old Trac system allowed to edit the Cc: field of a ticket to add one's username.

The new Trac only allows to edit the full Cc: field for a new ticket and to add one's email address to the Cc field of an existing ticket via checkbox.

The username is advantageous in not exposing the email address on the ticket's Web page and for allowing to change one's email address in the future.

Attachments (1)

add_cc.png (5.5 KB ) - added by umccullough 11 years ago.
image of new "add cc" functionality

Download all attachments as: .zip

Change History (20)

comment:1 by nielx, 11 years ago

Cc: nielx added

I think you lost me. What exactly is happening right now and how would you like it to be?

by umccullough, 11 years ago

Attachment: add_cc.png added

image of new "add cc" functionality

comment:2 by umccullough, 11 years ago

Mine shows it at the bottom now as a checkbox (see attached image).

comment:3 by umccullough, 11 years ago

Cc: umccullough@… added

Oh, i didn't read the whole description - the email is not shown - just like in the old version :)

comment:4 by nielx, 11 years ago

I get it.

Don't worry, your username is not exposed. You can only see your own email and not someone else's. Only administrators can see emails. That's the way it is currently set up.

You can check it out by adding yourself to the CC field and then click 'Log out' at the top of the page. That is what it looks like to innocent bystanders.

If you are satisfied with the situation I'd suggest we close this ticket.

comment:5 by umccullough, 11 years ago

I'm not the originator of the ticket, I was just commenting on what I see here for his sake :D

comment:6 by umccullough, 11 years ago

Ah, but let me point out - it *does* show the full email address in the notification that is emailed...

Niels, is there any way you can fix that to anonymize in a similar way?

comment:7 by andreasf, 11 years ago

Okay, it may not be visible to the outside but I'd still prefer the checkbox to add/remove my username rather than my email address.

Niels, what I did previously was I added in the Cc field ", andreasf"; now, via the checkbox, ", andreas.faerber (at) ..." is added. I would prefer if instead the username were used, to have the Trac preferences as the central place to administer my email address. (I have no idea if this is easy to change or not.)

comment:8 by andreasf, 11 years ago

On e.g. #1044 I am cc'ed as andreasf, and the checkbox is intelligent enough to recognize that and to allow removing me as andreasf. So it's only about adding oneself to Cc.

An example for the new-style cc is #2410.

in reply to:  4 comment:9 by koki, 11 years ago

Replying to nielx:

Don't worry, your username is not exposed. You can only see your own email and not someone else's. Only administrators can see emails. That's the way it is currently set up.

I doubt that I am an admin, and today I received a notification from Trac that showed somebody else's email as being added to the CC list. This was for ticket:

http://bugs.haiku-os.org/ticket/2458#comment:1

The email is obscured in Trac, but the email notification is sending out the full email address as is, and that is IMO undesired.

comment:10 by nielx, 11 years ago

Yes, it is. Due to illness I did not feel like browsing through the code this week. I will do this, but it will have to wait for a bit. Sorry.

comment:11 by umccullough, 11 years ago

Cc: umccullough@… removed

comment:12 by nielx, 10 years ago

Test whether email addresses are still visible on the mailing list.

comment:13 by nielx, 10 years ago

Cc: niels.reedijk@… added; nielx removed

comment:14 by nielx, 10 years ago

Resolution: fixed
Status: newclosed

Seems to be fixed now.

(Note that people with 'higher' Trac privileges are able to see the email addresses, but that is intended).

comment:15 by andreasf, 10 years ago

Resolution: fixed
Status: closedreopened

Actually the issue I opened this ticket for is not fixed:

In the "Change Properties" section below, as a regular user, I still see "Add to Cc: myemail@… [ ]", and it does add that specific email address to the CC list.

I was asking for "Add to Cc: andreasf [ ]" or similar, so that I can have my username added to the CC list in place of an email address, whether displayed partially or fully. Originally, I was able to manually type into the list of CCs, so that I could make this choice myself.

comment:16 by nielx, 10 years ago

Note to self:

The email is retrieved from trac/ticket/web_ui.py:

http://trac.edgewall.org/browser/trunk/trac/ticket/web_ui.py#L634

In theory by changing this line to retrieve the username instead of the email associated with the session, it might work again.

comment:17 by pulkomandy, 5 years ago

Milestone: R1

comment:18 by nielx, 4 weeks ago

Cc: andreasf added

comment:19 by nielx, 3 weeks ago

Resolution: fixed
Status: reopenedclosed

Fixed in Trac 1.4

Note: See TracTickets for help on using tickets.