Opened 11 years ago

Closed 10 years ago

#2431 closed enhancement (fixed)

[Tracker] missing shortcuts for icon views (easy)

Reported by: diver Owned by: stippi
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Alt+1 Shortcuts for some icon views:

40x40

48x48

64x64

Attachments (2)

2431.diff (1.4 KB) - added by maxime.simon 10 years ago.
More shortcuts for Tracker icon view mode.
2431b.diff (3.5 KB) - added by maxime.simon 10 years ago.
"Decrease/Increase size" shortcuts and menu item + old shortcuts for sizes of icons.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 11 years ago by diver

Summary: [Tracker] missing shortcuts for icon views[Tracker] missing shortcuts for icon views (easy)

Changed 10 years ago by maxime.simon

Attachment: 2431.diff added

More shortcuts for Tracker icon view mode.

comment:2 Changed 10 years ago by maxime.simon

Alt+1 -> 32x32
Alt+2 -> 40x40
Alt+3 -> 48x48
Alt+4 -> 64x64
Alt+5 -> mini icon view
Alt+6 -> list view

comment:3 Changed 10 years ago by stippi

Resolution: fixed
Status: newclosed

Cool, thanks! Applied in hrev29905.

comment:4 Changed 10 years ago by humdinger

Resolution: fixed
Status: closedreopened

Pardon me for re-opening this ticket, I have a minor concern. Don't you think this is quite a shortcut proliferation? We may want to save some in case we need 'em. :)

Do all these menu items even make sense? I mean, as a user I don't particularly care if my icons are 32x32, 40x40 or 64x64. I like them either larger or smaller. How about ALT +/- to simply in/decrease the size with only some sanity checking for a range of 16-128 pixel width. Maybe the stepping could be increased the bigger the icon gets, e.g. 4-pixel steps between size 16-32, 8-pixel steps between 32-64, 16 pixel steps between 64-128.

So the item "Icon View" will get the "ALT 1" again, a submenu gets a heading with the current size and below that "Increase size - Alt +" and "Decrease size - Alt -".

That way you'll also again have the 3 major modes icon/list/detail side by side with ALT 1,2,3 on the keyboard. Please re-consider this change. Thank you.

comment:5 Changed 10 years ago by aldeck

I agree with humdinger, i thought about an alternative solution, but stippi (which is sitting next to me :) had it commited before i could scratch my head and say 'hey wait' :D
At first i also thought about alt +/- like its done in some other applications/platforms, but in fact i think Alt-1 should just remember the size you prefer (the one you selected in the menu last time). It could be a per folder prefered size even, but i'm not sure about that.

Btw, those shortcuts aren't even accessible on some keymaps (french a least) where we need to 'shift' those keys to produce a number. Don't know what to do about that. Regards

comment:6 Changed 10 years ago by maxime.simon

Oh I agree and I thought it was not very smart to make a plethora of shortcuts, but it was the fastest. :)
So I am currently trying to make something more user-friendly, but we will have problems with some shortcuts (as aldeck said). For example the + isn't accessible without holding the 'shift' key, even on a qwerty keyboard (so let's imagine on an azerty :).

comment:7 Changed 10 years ago by axeld

The shortcut problem is something we cannot really tackle as part of this bug, so I would say: ignore it. It's not really *that* bad without those shortcuts, if you can't produce them. The whole shortcut system has to be rethought, anyway.

About the matter at hand, though, I agree that we shouldn't have all those shortcuts, and +/- sounds nice to me. I would leave the menu as is, though, and only add the shortcuts. This way you can still directly select the size you want via the mouse, and also could have the "preferred size" as suggested by Alexandre.

comment:8 Changed 10 years ago by maxime.simon

And what if we add the "Increase/Decrease size" menu item in the bottom of the Icon View submenu?
I mean, how people will know these shortcuts if we do not display?

So we keep Alt+1 for "32x32", we keep the other sizes in the menu, and we add two items: "Increase size", "Decrease size" with shortcuts Alt+ and Alt- (even if they don't work).

comment:9 Changed 10 years ago by stippi

Sounds fine to me. :-)

Changed 10 years ago by maxime.simon

Attachment: 2431b.diff added

"Decrease/Increase size" shortcuts and menu item + old shortcuts for sizes of icons.

comment:10 Changed 10 years ago by maxime.simon

It works, but I have some problems with the cleanup which doesn't work fine.

comment:11 Changed 10 years ago by stippi

Owner: changed from axeld to stippi
Status: reopenednew

I think it works fine as far as the broken icon placement currently allows for. Looking into it. Thanks for the patch!

comment:12 Changed 10 years ago by maxime.simon

It wasn't exactly a cleanup problem but rather an icon placement problem. (When I make a cleanup, the icons go anywhere…)

comment:13 Changed 10 years ago by aldeck

Resolution: fixed
Status: newclosed

closing, the enhancement has been implemented, issues mentioned in the last comments (if they still exist) should be (or are already) taken care in other tickets.

Note: See TracTickets for help on using tickets.