Opened 11 years ago

Closed 6 years ago

#2446 closed enhancement (fixed)

Add Cc: text field to mails shown when it's not empty (easy)

Reported by: axeld Owned by: czeidler
Priority: normal Milestone: R1
Component: Applications/Mail Version: R1/pre-alpha1
Keywords: gsoc2011 Cc: jalopeura@…
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

It would be nice to see the other recipients of a mail automatically, without needing to turn on the "show header" option.

To save space, the field should only be visible in case there actually are any Cc addressees.

Attachments (2)

mailccfix.patch (3.2 KB) - added by jdguzman 9 years ago.
fixed issue with exceeding the 80 char limit
maildiff.txt (1.7 KB) - added by jalopeura 8 years ago.
Patch

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by jdguzman

Trying out a patch for this issue today. Will attach patch if it is good.

comment:2 Changed 9 years ago by jdguzman

I have attached my work on this ticket. I have also tested and can confirm it to be working.

Changed 9 years ago by jdguzman

Attachment: mailccfix.patch added

fixed issue with exceeding the 80 char limit

comment:3 Changed 9 years ago by mmadia

Has a Patch: set

Changed 8 years ago by jalopeura

Attachment: maildiff.txt added

Patch

comment:4 Changed 8 years ago by jalopeura

I have added a patch to implement this. I do not know whether LoadMessage can be called multiple times, so I assumed it could be and coded to that (although I was unable to test whether loading multiple messages would work).

NOTE: I was unable to get to previous patch to work. Even applying the changes manually did not work, as it relied on already knowing, at the time the header controls are created, whether the CC field will be required. (Perhaps this was the case when the patch was created, but is no longer the case now.)

comment:5 Changed 8 years ago by jalopeura

Accidentally hit the back button on my browser and it resubmiited the patch. The last two patches are the same.

comment:6 Changed 8 years ago by jalopeura

Keywords: gsoc2011 added

comment:7 Changed 8 years ago by jalopeura

Cc: jalopeura@… added

comment:8 Changed 8 years ago by korli

Owner: changed from axeld to czeidler
Status: newassigned

Let's see if Clemens is interested.

comment:9 Changed 6 years ago by mmadia

To note, the patch attachment:maildiff.txt applies cleanly on current the master (hrev45296)

comment:10 Changed 6 years ago by leavengood

If it applies and works, I say commit it. The code looks decent enough, beyond the fact that Mail has a terrible old-school non-layout-aware GUI.

comment:11 Changed 6 years ago by mmadia

Resolution: fixed
Status: assignedclosed

Applied in hrev45418. Thanks for the patch!

Note: See TracTickets for help on using tickets.