Eject when unmounting not working. (gcc2 only)

[bga]

When a CD is unmounted it does not eject even when eject when unmounting is enabled in the Mount settings.

[vidrep]

This is still a valid bug in hrev48269 x86_gcc2 If "eject when unmounting" is selected in mount settings, disks do not eject after being unmounted (screenshot1).

[axeld]

It is also a very strange bug, and seems to be timing related; I investigated this one once, and adding a few debug output messages fixed the issue IIRC.

[vidrep]

This is still a valid bug in hrev48947. The description should probably change to something like "Unmounting Optical Disk; eject not working".

[vidrep]

I was having a look at similar tickets, and it looks like #5099 and #11492 could possibly be closed as duplicates of this ticket.

[axeld]

While those tickets mention the eject problem, they are both about adding a menu item to different components, not the actual issue mentioned here.

[vidrep]

I tested the most recent builds (hrev49132), and find it strange that 64 bit works fine, but 32 bit does not.

[pulkomandy]

Have you tried x86_gcc2 or x86 (gcc4)? It could be a compiler issue. It is known that the code for this is there, but not working reliably (possibly because there is a race condition: we try to eject the disk before it is fully unmounted). The result is that it works only sometimes (when the timing is right). Since the timing is different for each compiler and architecture (different cpu instructions used, etc), it's not very surprising that some work better than others.

[vidrep]

I tested with hrev49132 x86_gcc2 and hrev49132 x86_64. I'll try a gcc4 build to see if it makes a difference.

[vidrep]

I tried hrev49132 x86 and it works correctly.

[vidrep]

OK. I downloaded and installed each build of hrev49132 (x86_gcc2, x86_gcc2_hybrid, x86_gcc4, x86_gcc4_hybrid) and hrev49123 x86_64. I tested each one multiple times for eject on unmount, using an optical disk. The only ones NOT working are x86_gcc2 and x86_gcc2_hybrid.

[pulkomandy]

Fixed in hrev49136.

[vidrep]

Now working correctly, including when burning a CD with CDRecord with the "-eject" flag. Previously, when burning a disk, if the "-eject" flag was used, CDRecord would eject the CD prior to the burn, rather than after completion. Thanks for taking care of this!