listdev does not list the device types anymore (patch)

[PieterPanman]

Attached is a patch that fixes the problem with the device type in the listdev output. See this line:

device Unclassified device (Non-VGA unclassified device) [0|0|0]

For some reason the relevant attributes are now B_UINT16_TYPE instead of B_UINT8_TYPE. It checked for the attribute name and type, so when the type did not match, the true value was not used, but the default 0 was used.

[PieterPanman]

listdev patch

[jackburton]

Tested ok. Committing.

[jackburton]

On second thought... how come the types are B_UINT16_TYPE but the code reads

pci_class_api_id = attr.value.ui8 ?

Shouldn't we change it to attr.value.ui16 ?

[PieterPanman]

I was just typing a message about this, yes, that doesn't make sense at all! If we do that, we should also change their declarations to uint16:

uint8 pci_class_base_id = 0;
uint8 pci_class_sub_id = 0;
uint8 pci_class_api_id = 0;

I'm not sure about the underlying reason for the change of uint8 to uint16, but we should change all 3 properly. Sorry about that :)

[jackburton]

Applied (with the above changes) in hrev27195. Thanks!