Opening files by dragging to Deskbar

[humdinger]

This is on vmware, hrev27404.

Say, you have Pe running.

Drag&drop of a text file on its entry in the Deskbar should open the file in Pe. It doesn't.

Drag&drop the text file on Tracker's entry in the Deskbar should open the file in text/plain's preferred app (StyledEdit). It doesn't.

Oh, and with all the dragging action, there's still #1813.

But: Drag the text file on Tracker's entry in the Deskbar and then move on and drop it on the (Leaf) Deskbar Menu and it opens in text/plain's preferred app (StyledEdit).

Dragging it onto the Deskbar and navigating through the Deskbar menu to Applications to drop it on StyledEdit works.

[axeld]

I've investigated a bit, and the feature works fine if the Deskbar is in compact mode. In the normal mode, menu tracking also doesn't stop when releasing the mouse button, instead it enters sticky mode (MenuBar.cpp, line 573).

Unfortunately, the menu code is nothing I would understand just by looking at it :-/

[jackburton]

Are we sure it used to work on beos ? Because if it did, it's a bug in BMenuBar, otherwise it's a bug in Deskbar.

[axeld]

It definitely works fine on BeOS.

[axeld]

The investigation above should also clearly point to the bug: it just must not enter sticky mode when dragging stuff around, at least I can't see how this could ever be correct.

[jackburton]

Well, the menu code has no concept of "dragging", anyway. The bug could have been exposed by the fact that our BMenuBar behave a bit differently than beos: it selects items not only when the mouse button is pressed, but also when it's released (this is only a speculation, I didn't dive into it very much).

[jackburton]

I had a look. The problem is that BarView sets the _menu_info_ptr_->click_to_open flag to false. This flag is used in the beos implementation to check if a menu is sticky or not (there was a static BMenu::IsStickyPrefOn() method, which we removed since we decided that non-sticky menus didn't make sense). So our implementation doesn't check that flag at all. By the way, the fact that BarView uses that private variable isn't that nice, we should try to fix it in a different way, if possible.

[jackburton]

Replying to jackburton:

I had a look. The problem is that BarView sets the _menu_info_ptr_->click_to_open flag to false.

In BarView::DragStart(), btw.

[stippi]

Fixed in hrev28063.

[humdinger]

It's indeed fixed. Thanks. Looks like it also solved #1813.