Opened 11 years ago

Closed 10 years ago

#2829 closed enhancement (fixed)

Changing shortcut and item name of "Force Identify"

Reported by: humdinger Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

My revision is hrev28069.

As I threatened at BeGeistert, here are some minor things for Alexandre. :)

There's an item "Identify" in Tracker's file menu and context menu. It sets the filetype of files that don't have one yet.

By holding down the command key (option key? No idea, it's AltGr to the right of the space key on my keymap), "Identify" also corrects a wrongly set filetype. At least it sets the filetype it's convinced is correct.

There are already a few items that change slightly when holding the SHIFT key (see e.g. Cut/Copy/Paste or Clean Up in the Window menu).

I propose to also use the SHIFT key as modifier for the identifying.

We should also reflect the slightly changed function in the item name. Generally, it's desirable to keep the first word "Identify" so not to confuse the user. I suggest: "Identify & Correct".

Change History (3)

comment:1 Changed 10 years ago by aldeck

While i was looking at this, i couldn't find a test case where a "force identify" is needed. I slightly remember you had one, care to refresh me? :)

In fact, i don't think i ever had to click the "identify" menu item, when i right click on a file, it gets identified automatically, so i never have to select "identify".

BTW, i'm sure i'm missing something here, but what's preventing us to always identify without user intervention?

comment:2 Changed 10 years ago by humdinger

I finally remembered why there is a "force identify":

Assign "text/plain" to a PNG file and "Identiy" won't correct it back to PNG. "Force Identify" does.

Now, it can be argued that a) "Identify" is useless because as soon as you right click an unknown file, it's identified automatically. And b), how practical is the scenario with a wrongly set MIME type? Maybe after downloading files from misconfigured servers? I don't know.

The solution I'd prefer, if the feature for scenarion b) is needed at all, is to have another button "Auto-detect" in the FileType Add-On besides the "Select..." and "Same As...".

Thanks for looking into it!

comment:3 Changed 10 years ago by aldeck

Resolution: fixed
Status: newclosed

Finally managed to implement that in hrev29940, sorry for the delay Humdinger ;) Had a few words with Axel and, as i said in the commit message, we will get rid of this 'issue' once identification gets automated.

Note: See TracTickets for help on using tickets.