BGradient draws junk when endpoints are not fully defined

[sdeken]

To reproduce: Construct, for example, a radial gradient with two defined endpoints:

BPoint center(50, 50);
float radius = 50.0;
BGradientRadial g(center, radius);
g.AddColor((rgb_color){ 255, 255, 255, 255 }, 0.0);
g.AddColor((rgb_color){ 255, 0, 0, 255 }, 10.0);
FillEllipse(center, radius, radius, g);    

Actual result: Part of the center portion of the ellipse is filled with a transition from white to red, but the remainder is filled with concentric bands of random color.

Expected result: Part of the center portion of the ellipse is filled with a transition from white to red, and the remainder of the ellipse is filled with red.

[aldeck]

Spotted the problem while working on a webkit bug. Color stops positions are in the range 0-255. If the first color stop position is > 0, then the begining of the gradient array is left uninitialized. Respectively for the last stop if it's not at 255.

Will fix soon. Btw what's the opinion about making the range 0.0f - 1.0f ? it's already a float.

Also, an out of range value (v < 0 or v > 255) crashes the app server. We need some validity checking.

[axeld]

Replying to aldeck:

Will fix soon. Btw what's the opinion about making the range 0.0f - 1.0f ? it's already a float.

Makes sense to me, at least.

Also, an out of range value (v < 0 or v > 255) crashes the app server. We need some validity checking.

Sounds like it :-)

[pulkomandy]

Fixed in hrev48447.