Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#319 closed bug (fixed)

Workspaces improperly displaying grid

Reported by: mattmadia@… Owned by: axeld
Priority: low Milestone: R1
Component: Applications Version:
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

hrev16823

"#W" refers to the number of workspaces as defined by the Screen preflet.

workspaces that display properly, there's two sets. 1) #W = 3 * K, where K is an ODD number { 1 , 3 , 5, 7, 9 }

#W = { 9, 15, 21, 27 } displayed 3 across, K down.

2) #W = 5 x 5 = 25

displayed 5 across, 5 down.

all odd #W, not including ( 9, 15, 21, 25, and 27 ) display as a single long row.

all even #W are displayed as 2 across, #W/2 down.

Change History (7)

comment:1 by korli, 14 years ago

18 is shown as 2 rows, 9 columns instead of 3 rows, 6 columns 12 is shown as 2 rows, 6 columns instead of 3 rows, 4 columns etc... everything else seems correct (11 is shown correctly as 11 columns ...)

comment:2 by korli, 14 years ago

Owner: changed from sikosis to axeld

comment:3 by korli, 14 years ago

Maybe this simple patch would make it:

Index: src/servers/app/WorkspacesLayer.cpp =================================================================== --- src/servers/app/WorkspacesLayer.cpp (revision 16889) +++ src/servers/app/WorkspacesLayer.cpp (working copy) @@ -43,7 +43,7 @@

int32 count = settings.WorkspacesCount();

rows = 1;

  • for (int32 i = 2; i < count; i++) {

+ for (int32 i = 2; i < count/2; i++) {

if (count % i == 0)

rows = i;

}

comment:4 by axeld, 14 years ago

Status: newclosed

comment:5 by axeld, 14 years ago

Resolution: fixed

comment:6 by axeld, 14 years ago

Component: PreferencesApplications

comment:7 by korli, 14 years ago

bug_group: developers
Note: See TracTickets for help on using tickets.