Opened 10 years ago

Closed 4 years ago

#3314 closed enhancement (fixed)

[Network] add a checkbox to put NetworkStatus into Deskbar

Reported by: diver Owned by: axeld
Priority: normal Milestone: R1
Component: Preferences/Network Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

I think that NetworkStatus is so tiny app that it should be integreated in Network preflet just as a checkbox like "Live in Deskbar" or "Show Network Status on Deskbar" like it is done in Media preflet

Attachments (1)

deskbarnetw.diff (8.2 KB) - added by Barrett 8 years ago.
updated patch for ticket #3314 and little improvements.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 10 years ago by mmlr

You miss the fact that it is also a replicant. I for example have it sit on my desktop instead of the deskbar to have it a bit bigger. So you need a resizable window with the replicant to get it, and that's exactly what the NetowkrStatus applet is for.

comment:2 Changed 10 years ago by axeld

Agreed, though we could still add a checkbox to the network preferences to put it into the deskbar :-)

comment:3 Changed 9 years ago by diver

Version: R1/pre-alpha1R1/Development

comment:4 Changed 8 years ago by diver

Summary: [Network] integrate NetworkStatus[Network] add a checkbox to put NetworkStatus into Deskbar

comment:5 Changed 8 years ago by Barrett

i've done that in my old patch for the network preflet : http://dev.haiku-os.org/attachment/ticket/820/preflet.patch (see NetworkView::_InstallInDeskbar()... methods)

The actual source code is too similar, and i can make easily a patch. My plans are to add a new simple NetworkView class, move the revert button in the NetworkView under the EthernetSettingsView, and add the checkbox "Install NetworkStatus in Deskbar". Would be appreciated?

comment:6 Changed 8 years ago by humdinger

Does that mean you want to merge NetworkStatus and the Network preferences?

If not, I don't see where to add a checkbox to NetworkStatus. If you work on a menu item for the context menu, it'd be nice if you could do it also for PowerStatus and have it just like in ProcessController. There it's a toggleable entry "Live in Deskbar". I like "Install in Deskbar" better, but since you'll have the same context menus in window mode and Deskbar mode, only "Live in Deskbar" is usable in both modes.
With this menu item in place, the installation-alert after launching could go.
Media's volume control could also do with a "Quit" menu item or, to have it more consistent, a checked "Live in Deskbar" entry.

comment:7 in reply to:  6 ; Changed 8 years ago by axeld

Replying to humdinger:

Does that mean you want to merge NetworkStatus and the Network preferences?

I think you managed to misunderstood Barrett completely. Despite that, I found the need to comment some of your ideas :-)

I like "Install in Deskbar" better, but since you'll have the same context menus in window mode and Deskbar mode, only "Live in Deskbar" is usable in both modes.

I would also prefer "Install in Deskbar" over "Live in Deskbar", and I would also prefer "Remove from Deskbar" over "Quit", as the latter is at least ambiguous (after all, those little icons aren't running applications).

With this menu item in place, the installation-alert after launching could go.

I don't think this would be as usable as the current solution.

Media's volume control could also do with a "Quit" menu item or, to have it more consistent, a checked "Live in Deskbar" entry.

Consistent with ProcessController, but nothing else yet; "Quit" would make it consistent with NetworkStatus, but nothing else yet :-)

I guess we're free to choose a better solution.

comment:8 in reply to:  7 ; Changed 8 years ago by humdinger

Replying to axeld:

I would also prefer "Install in Deskbar" over "Live in Deskbar", and I would also prefer "Remove from Deskbar" over "Quit", as the latter is at least ambiguous (after all, those little icons aren't running applications).

Consistent with ProcessController, but nothing else yet; "Quit" would make it consistent with NetworkStatus, but nothing else yet :-)

Would it be acceptable to name it "Show in Deskbar" (checkmarkable)? Then we wouldn't need different items when in windowed mode ("Install in Deskbar") and simply removing the checkmark in Deskbar mode saves us from calling the item there "Remove from Deskbar". "Show" sounds to me less anthropomorphized and cute than "Live".

comment:9 in reply to:  8 Changed 8 years ago by anevilyak

Replying to humdinger:

Would it be acceptable to name it "Show in Deskbar" (checkmarkable)? Then we wouldn't need different items when in windowed mode ("Install in Deskbar") and simply removing the checkmark in Deskbar mode saves us from calling the item there "Remove from Deskbar". "Show" sounds to me less anthropomorphized and cute than "Live".

It's not really a matter of anthropomorphics though ; the use of "Live" was specifically intended with the connotations that it persists there after the app goes away. "Show in Deskbar" doesn't really have that same implication, and could leave it ambiguous if the deskbar icon's going to stay there when the app exits or not. Not all Deskbar replicants are persistent after all (i.e. status indicator for an IM app would not be).

comment:10 Changed 8 years ago by Barrett

Has a Patch: set

comment:11 Changed 8 years ago by Barrett

A patch would be good as explanation : )..the patch implement the functionality, and add also a textcontrol that allow you to set the hostname of the pc. I've not moved the apply/revert buttons outside the EthernetSettingsView, because there's not an elegant solution, IMHO could be done with more work (addons and waldemar's design).

Changed 8 years ago by Barrett

Attachment: deskbarnetw.diff added

updated patch for ticket #3314 and little improvements.

comment:12 Changed 4 years ago by diver

Has a Patch: unset

comment:13 Changed 4 years ago by pulkomandy

Resolution: fixed
Status: newclosed

Fixed in hrev48623.

Note: See TracTickets for help on using tickets.