[Installer] alert view for eula isn't wide enough (easy)

[diver]

Currently alert view for eula isn't wide enough and force text wrapping even though there are more free space left. Fixing it will probably remove a need in scrollbar and improove the look. Also adding a 3 pixel offset before text wouldn't hurt. The view itself looks like selectable, but it's not, maybe it should?

[korli]

Hopefully improved in hrev29005. Please check.

[diver]

Much better now! But the EULA window must be centered, see attached screenshot (this is how it is now)

[korli]

I tested myself and its window is centered here.

[diver]

That's strange, I've rebuilt an image and it still not centered.

[korli]

weird. Could you try with this patch and provide the terminal output ?

Index: src/apps/installer/InstallerApp.cpp
===================================================================
--- src/apps/installer/InstallerApp.cpp (révision 29005)
+++ src/apps/installer/InstallerApp.cpp (copie de travail)
@@ -47,6 +47,8 @@
        box->AddChild(alertView);
        parent->AddChild(box);
        BRect alertFrame = alert->Frame();
+       frame.PrintToStream();
+       alertFrame.PrintToStream();
        alertFrame.OffsetTo((frame.Width() - alertFrame.Width()) / 2,
                (frame.Height() - alertFrame.Height()) / 2);
        alert->MoveTo(alertFrame.LeftTop());

[diver]

Here you are.

[korli]

I have got the very same values and it's centered. Are you on emulation or real hardware ?

[diver]

Oh, nevermind, I rm'ed src/apps/installer and rebuilt it again, and everything fine now.

[korli]

ok !