Opened 11 years ago

Closed 11 years ago

#3321 closed enhancement (fixed)

[Installer] alert view for eula isn't wide enough (easy)

Reported by: diver Owned by: korli
Priority: normal Milestone: R1
Component: Applications/Installer Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Currently alert view for eula isn't wide enough and force text wrapping even though there are more free space left. Fixing it will probably remove a need in scrollbar and improove the look. Also adding a 3 pixel offset before text wouldn't hurt. The view itself looks like selectable, but it's not, maybe it should?

Attachments (2)

eula.png (102.1 KB ) - added by diver 11 years ago.
eula2.png (110.4 KB ) - added by diver 11 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 by korli, 11 years ago

Hopefully improved in hrev29005. Please check.

comment:2 by diver, 11 years ago

Much better now! But the EULA window must be centered, see attached screenshot (this is how it is now)

by diver, 11 years ago

Attachment: eula.png added

comment:3 by korli, 11 years ago

I tested myself and its window is centered here.

comment:4 by diver, 11 years ago

That's strange, I've rebuilt an image and it still not centered.

comment:5 by korli, 11 years ago

weird. Could you try with this patch and provide the terminal output ?

Index: src/apps/installer/InstallerApp.cpp
===================================================================
--- src/apps/installer/InstallerApp.cpp (révision 29005)
+++ src/apps/installer/InstallerApp.cpp (copie de travail)
@@ -47,6 +47,8 @@
        box->AddChild(alertView);
        parent->AddChild(box);
        BRect alertFrame = alert->Frame();
+       frame.PrintToStream();
+       alertFrame.PrintToStream();
        alertFrame.OffsetTo((frame.Width() - alertFrame.Width()) / 2,
                (frame.Height() - alertFrame.Height()) / 2);
        alert->MoveTo(alertFrame.LeftTop());

by diver, 11 years ago

Attachment: eula2.png added

comment:6 by diver, 11 years ago

Here you are.

comment:7 by korli, 11 years ago

I have got the very same values and it's centered. Are you on emulation or real hardware ?

comment:8 by diver, 11 years ago

Oh, nevermind, I rm'ed src/apps/installer and rebuilt it again, and everything fine now.

comment:9 by korli, 11 years ago

Resolution: fixed
Status: newclosed

ok !

Note: See TracTickets for help on using tickets.