Opened 16 years ago
Closed 15 years ago
#3395 closed enhancement (fixed)
Saving images locally (patch)
Reported by: | humdinger | Owned by: | stippi |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Applications/CodyCam | Version: | R1/pre-alpha1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
This is hrev29096.
It has been mentioned on the mailinglist a while back: Besides storing the captures via FTP it may be useful to also offer an option to save them locally on your machine.
Attachments (1)
Change History (7)
comment:1 by , 16 years ago
comment:2 by , 16 years ago
A very simple enhancement but the FTP nature of the application is very deeply rooted. To use local outputting set output type to LOCAL. Setting directory will tell CodyCam where the file is to go. No file permissions checking implemented.
comment:3 by , 16 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Thanks a lot for the patch! A few improvements are possible:
1) I'd call it "Local" versus "LOCAL". 2) Constructing the file path. You should allocate a string buffer on the stack with length "B_PATH_NAME_LENGTH" and then snprintf() the controls contents into that. 3) One small coding style issues: The "else" goes on the same line as the closing "}" from the preceding "if" block.
by , 16 years ago
Attachment: | codycam.diff added |
---|
Diff to allow Local saving (updated with stippi's improvements)
comment:4 by , 15 years ago
Ping. There was a patch attached 6 months ago by gamblore, that possibly hasn't been reviewed.
comment:5 by , 15 years ago
Summary: | Saving images locally (easy) → Saving images locally (patch) |
---|
Added (patch) to summary so the ticket is easily found when querying for open patches. Thanks for spotting this, v.
comment:6 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Applied with some additional tweaks in hrev33682. Terribly sorry about the commit message, now I see the patch was by gamblore, not v.
I may add that you can use eXposer for that. Even if it's only the demo version. It offers a lot more features too, while you capture your images.