Opened 10 years ago

Closed 10 years ago

#3596 closed enhancement (fixed)

Change from lexicographic sorting to natural sorting

Reported by: plasm Owned by: stippi
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Right now, files are sorted a1, a10, a100, a1000, a101, a11. Sorting should be done naturally, which would yeild a1, a10, a11, a100, a101, a1000

Attachments (1)

natural_sort.patch (3.9 KB) - added by plasm 10 years ago.
Implements the desired functionality

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by aldeck

Talked to plasm on #haiku, commenting so that everyone on haiku-bugs mailing list gets notified. Will have a look this weekend unless someone beats me to it :)

comment:2 Changed 10 years ago by plasm

I made a mistake when updating the attachment (forgot to check the box indicating I wanted it to replace the old one), so it appended a '2' on the end... I would appreciate it if someone could delete the second patch (with the '2'), and I will reupload it... this time making sure it replaces the original patch.

comment:3 Changed 10 years ago by stippi

Ok, I deleted the second attachment for you. Before you attach the improved patch again, please make sure to cleanup the coding style violations. See the file

<http://www.haiku-os.org/documents/dev/haiku_coding_guidelines>

comment:4 Changed 10 years ago by plasm

Okay, I cleaned up the patch, and re-uploaded it. Let me know if there are still style violations.

comment:5 Changed 10 years ago by aldeck

It seems most of those i pointed you on irc are still there. Please read the coding guidelines carefully. Regards

comment:6 Changed 10 years ago by stippi

Yes, I agree with aldeck. It's great that you worked on this patch! But anyone who is going to commit it will have to clean up the coding style violations. It's much better if you do this, so you learn these guidelines for when coding something for Haiku. Hope you understand! :-)

Changed 10 years ago by plasm

Attachment: natural_sort.patch added

Implements the desired functionality

comment:7 Changed 10 years ago by mmadia

patch appears to have been updated.

comment:8 Changed 10 years ago by stippi

Yes, much better now.

comment:9 Changed 10 years ago by stippi

Owner: changed from axeld to stippi
Status: newassigned

comment:10 Changed 10 years ago by stippi

Resolution: fixed
Status: assignedclosed

Thanks a lot! I've commited the patch with some modifications for clarity and which hopefully improve speed a bit in hrev29845.

Note: See TracTickets for help on using tickets.