Opened 16 years ago
Closed 7 years ago
#3603 closed enhancement (fixed)
BuildSetup : check for correct version of jam
| Reported by: | mmadia | Owned by: | bonefish |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Build System | Version: | R1/pre-alpha1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Patch allows configure to check if 'jam -v' returns the expected version string. If not, configure displays an error message and exits.
I understand that this patch does not support the situation where the user has haiku's jam installed as a filename other than 'jam'. IMO, that is a special case and should not be handled by the build system.
Attachments (3)
Change History (7)
by , 16 years ago
| Attachment: | configureJamVersion.patch added |
|---|
follow-up: 2 comment:1 by , 16 years ago
comment:2 by , 16 years ago
| Milestone: | R1/alpha1 |
|---|---|
| Summary: | [patch] configure : check for correct version of jam → BuildSetup : check for correct version of jam |
Replying to umccullough:
It's highly likely that any future fixes to jam and this version check will go unnoticed by many because they will just svn up && jam -q without ever encountering this check.
Ahh, I understand now. modifying summary to reflect this change in design. modifying Milestone to empty as this shouldn't hold up R1/alpha1
comment:3 by , 15 years ago
The first patch, jam-define-JAMVERSION.patch updates jam to a more recent time stamp and syncs the variable JAMVERSION. The latter, check-jam-version.patch checks the invoked jam's version and exits if it doesn't match the required version. Thoughts on applying?
comment:4 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Implemented a somewhat different version of this in hrev51640.
I still think this would be better served by adding a check somewhere in a Jamfile that is always evaluated when the user invokes jam on the Haiku sources :)
An update to jam does not require reconfigure, nor does configure require jam to proceed. Thus, it should *not* be a requirement to have jam installed to build the cross tools (as it currently isn't).
It's highly likely that any future fixes to jam and this version check will go unnoticed by many because they will just svn up && jam -q without ever encountering this check.